Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] gateway2/delegation: enable inherited policy overrides (#10470) #10497

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

shashankram
Copy link

Description

Backports 1bed380 from main

Adds the ability to override inherited policy fields when explicitly permitted by a parent route using the annotation delegation.gateway.solo.io/enable-policy-overrides. It supports a wildcard value "*" or a comma separated list of field names such as "faults,timeouts,retries,headermanipulation".

Functionally, a child RouteOption may only override the RouteOptions derived from its parent if the above annotation exists on the parent route. This is required to make the override behavior safe to use.


Testing done:

  • Translator tests for the new scenarios.
  • Repro script provided by Arka

Testing steps

Use the examples added in the translator tests to verify the override behavior of inherited policies with delegation.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation TODO
  • I have added tests that prove my fix is effective or that my feature works

@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/7315

@shashankram shashankram enabled auto-merge (squash) December 17, 2024 16:17
@shashankram shashankram merged commit 0382900 into v1.18.x Dec 17, 2024
18 checks passed
@shashankram shashankram deleted the shashankram/backport_fix-sp-7315 branch December 17, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants