Solo APIs. @tag-name=sa-k8s-1.28-bump #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjumani
force-pushed
the
bump-k8s-128
branch
from
460bdac to
9afa212
Compare
jenshu
reviewed
Dec 5, 2023
jenshu
reviewed
Dec 5, 2023
| storage: true | ||
|
|
||
| --- | ||
| apiVersion: apiextensions.k8s.io/v1beta1 |
There was a problem hiding this comment.
note to future reviewers: we don't care about the deletion of the failoverscheme crd because gloo (the only user of the gloo-repo-branch branch) doesn't reference the crds from solo-apis
jenshu
approved these changes
Dec 6, 2023
|
Given the conversations we had around why this branch exists, and what alternatives we considered, I think it would be helpful if we persisted those findings somewhere for future developers to discover. I could see value in any of the following places:
|
|
Added docs around this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump to k8s 1.28
Updates the latest rate-limit protos as of 2023-12-05
Updates skv2 and adds the corresponding flags to mitigate breaking changes