Fix styling

.rubocop.yml

@@ -1,55 +1,22 @@
 require:
-  - rubocop-performance
   - rubocop-rspec
+  - rubocop-performance
+
+# Omakase Ruby styling for Rails
+inherit_gem:
+  rubocop-rails-omakase: rubocop.yml
 
 AllCops:
   NewCops: enable
 
 Style/FrozenStringLiteralComment:
   Enabled: false
 
-Style/StringLiterals:
-  EnforcedStyle: double_quotes
-
-Layout/LineLength:
-  Max: 100
-  Exclude:
-    - app/views/**/*.html.haml
-
-Style/Documentation:
-  Enabled: false
-
-Style/ClassAndModuleChildren:
-  Enabled: false
-
-Metrics/BlockLength:
-  Enabled: true
-  Exclude:
-    - "**/spec/**/*.rb"
-
-Style/BlockDelimiters:
-  Enabled: true
-  Exclude:
-    - "**/spec/**/*.rb"
-
-Style/NumericLiterals:
+RSpec/DescribedClass:
   Enabled: false
 
-Style/FormatStringToken:
+RSpec/ExampleLength:
   Enabled: false
 
 RSpec/MultipleExpectations:
   Enabled: false
-
-RSpec/ExampleLength:
-  Max: 30
-
-RSpec/DescribeClass:
-  Enabled: true
-  Exclude:
-    - "**/spec/system/**/*.rb"
-    - "**/spec/requests/**/*.rb"
-    - "**/spec/views/**/*.rb"
-
-RSpec/DescribedClass:
-  Enabled: false

components/app/Gemfile

@@ -21,9 +21,9 @@ gem "sucker_punch"
 gem "tts_voices", github: "somleng/tts_voices"
 
 group :development, :test do
-  gem "rubocop"
-  gem "rubocop-performance"
-  gem "rubocop-rspec"
+  gem "rubocop-rails-omakase", require: false
+  gem "rubocop-performance", require: false
+  gem "rubocop-rspec", require: false
 end
 
 group :test do

components/app/Gemfile.lock

@@ -253,9 +253,22 @@ GEM
       rubocop (~> 1.41)
     rubocop-factory_bot (2.25.1)
       rubocop (~> 1.41)
+    rubocop-minitest (0.35.0)
+      rubocop (>= 1.61, < 2.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
     rubocop-performance (1.20.2)
       rubocop (>= 1.48.1, < 2.0)
       rubocop-ast (>= 1.30.0, < 2.0)
+    rubocop-rails (2.24.0)
+      activesupport (>= 4.2.0)
+      rack (>= 1.1)
+      rubocop (>= 1.33.0, < 2.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
+    rubocop-rails-omakase (1.0.0)
+      rubocop
+      rubocop-minitest
+      rubocop-performance
+      rubocop-rails
     rubocop-rspec (2.27.1)
       rubocop (~> 1.40)
       rubocop-capybara (~> 2.17)
@@ -347,8 +360,8 @@ DEPENDENCIES
   reel!
   reel-rack!
   rspec
-  rubocop
   rubocop-performance
+  rubocop-rails-omakase
   rubocop-rspec
   sentry-ruby
   simplecov

components/app/app/models/twiml/connect_verb.rb

@@ -4,7 +4,7 @@ module TwiML
   class ConnectVerb < TwiMLNode
     class StreamNoun < TwiMLNode
       class Parser < TwiML::NodeParser
-        VALID_NOUNS = ["Parameter"].freeze
+        VALID_NOUNS = [ "Parameter" ].freeze
 
         def parse(node)
           super.merge(parameters: build_parameters)
@@ -85,7 +85,7 @@ def value
     end
 
     class Parser < TwiML::NodeParser
-      VALID_NOUNS = ["Stream"].freeze
+      VALID_NOUNS = [ "Stream" ].freeze
 
       def parse(node)
         super.merge(stream_noun:)

components/app/app/models/twiml/loop_attribute.rb

@@ -11,7 +11,7 @@ def initialize(value)
     def times
       return MAX_LOOP.times if value.to_s == "0"
 
-      [(value || 1).to_i, MAX_LOOP].min.times
+      [ (value || 1).to_i, MAX_LOOP ].min.times
     end
   end
 end

components/app/app/workflows/execute_dial.rb

@@ -20,7 +20,7 @@ def call
   private
 
   def redirect(params)
-    throw(:redirect, [verb.action, verb.method, params])
+    throw(:redirect, [ verb.action, verb.method, params ])
   end
 
   def build_callback_params(dial_status)

components/app/app/workflows/execute_gather.rb

@@ -29,7 +29,7 @@ def call
   private
 
   def redirect(params)
-    throw(:redirect, [verb.action, verb.method, params])
+    throw(:redirect, [ verb.action, verb.method, params ])
   end
 
   def build_callback_params(digits)
@@ -52,11 +52,11 @@ def ask_parameters
 
   def build_ask_parameter(nested_verb)
     parameter = case nested_verb.name
-                when "Say"
+    when "Say"
                   build_say_parameter(nested_verb)
-                when "Play"
+    when "Play"
                   build_play_parameter(nested_verb)
-                end
+    end
 
     parameter.repeat = nested_verb.loop.times.count
     parameter

components/app/app/workflows/execute_record.rb

@@ -43,7 +43,7 @@ def normalize_recording_url(raw_recording_url)
   end
 
   def redirect(params)
-    throw(:redirect, [verb.action, verb.method, params])
+    throw(:redirect, [ verb.action, verb.method, params ])
   end
 
   def build_callback_params(response, record_result)

components/app/app/workflows/execute_redirect.rb

@@ -10,6 +10,6 @@ def call
   private
 
   def redirect
-    throw(:redirect, [verb.content, verb.method])
+    throw(:redirect, [ verb.content, verb.method ])
   end
 end

components/app/config/initializers/aws_stubs.rb

@@ -33,8 +33,8 @@ def to_h
     stub_responses: {
       describe_voices: {
         voices: [
-          { gender: "Female", id: "Joanna", language_code: "en-US", supported_engines: ["standard"] },
-          { gender: "Female", id: "Lotte", language_code: "nl-NL", supported_engines: ["neural"] },
+          { gender: "Female", id: "Joanna", language_code: "en-US", supported_engines: [ "standard" ] },
+          { gender: "Female", id: "Lotte", language_code: "nl-NL", supported_engines: [ "neural" ] },
           { gender: "Female", id: "Vitoria", language_code: "pt-BR", supported_engines: %w[neural standard] }
         ]
       }

components/app/lib/encrypted_credentials.rb

@@ -22,7 +22,7 @@ def credentials
     end
 
     def edit
-      Tempfile.open([file_path.basename.to_s.chomp(".enc"), ".yml"]) do |tmp_file|
+      Tempfile.open([ file_path.basename.to_s.chomp(".enc"), ".yml" ]) do |tmp_file|
         if file_path.exist?
           tmp_file.write(read_credentials)
           tmp_file.flush
@@ -64,13 +64,13 @@ def handle_missing_key
 
     def encrypt(content)
       cipher = OpenSSL::Cipher.new(CIPHER).encrypt
-      cipher.key = [key].pack("H*")
+      cipher.key = [ key ].pack("H*")
       cipher.update(content) + cipher.final
     end
 
     def decrypt(content)
       cipher = OpenSSL::Cipher.new(CIPHER).decrypt
-      cipher.key = [key].pack("H*")
+      cipher.key = [ key ].pack("H*")
       cipher.update(content) + cipher.final
     end
   end

components/app/lib/rayo/command/twilio_stream/base.rb

@@ -12,7 +12,7 @@ def api
         end
 
         def args
-          [uuid, command_name, *command_args, Base64.urlsafe_encode64(metadata)].compact
+          [ uuid, command_name, *command_args, Base64.urlsafe_encode64(metadata) ].compact
         end
 
         def command_args

components/app/lib/rayo/command/twilio_stream/start.rb

@@ -13,7 +13,7 @@ def command_name
         end
 
         def command_args
-          [url]
+          [ url ]
         end
       end
     end

components/app/spec/call_controllers/dial_spec.rb

@@ -27,7 +27,7 @@
 
     it "dials to plain text", :vcr, cassette: :build_routing_parameters do
       controller = build_controller(
-        stub_voice_commands: [:play_audio, { dial: build_dial_status }],
+        stub_voice_commands: [ :play_audio, { dial: build_dial_status } ],
         call_properties: {
           account_sid: "ea471a9f-d4b3-4035-966e-f507b8da6d34",
           from: "855715100860",
@@ -55,7 +55,7 @@
 
     it "handles national dialing", :vcr, cassette: :build_routing_parameters_with_national_dialing do
       controller = build_controller(
-        stub_voice_commands: [:play_audio, { dial: build_dial_status }],
+        stub_voice_commands: [ :play_audio, { dial: build_dial_status } ],
         call_properties: {
           account_sid: "ea471a9f-d4b3-4035-966e-f507b8da6d34",
           to: "855715100860",
@@ -81,7 +81,7 @@
 
     it "handles numbers without symmetric latching support", :vcr, cassette: :build_routing_parameters_without_symmetric_latching do
       controller = build_controller(
-        stub_voice_commands: [{ dial: build_dial_status }],
+        stub_voice_commands: [ { dial: build_dial_status } ],
         call_properties: {
           account_sid: "ea471a9f-d4b3-4035-966e-f507b8da6d34"
         }

components/app/spec/call_controllers/gather_spec.rb

@@ -85,7 +85,7 @@
             </Response>
           TWIML
 
-          stub_twiml_request(controller, response: [first_response, second_response])
+          stub_twiml_request(controller, response: [ first_response, second_response ])
 
           controller.run
 
@@ -146,7 +146,7 @@
 
         it "falls through the the next verb in the TwiML document if no input is received" do
           controller = build_controller(
-            stub_voice_commands: [:play_audio, { ask: build_input_result(nil) } ]
+            stub_voice_commands: [ :play_audio, { ask: build_input_result(nil) } ]
           )
 
           stub_twiml_request(controller, response: <<~TWIML)

components/app/spec/call_controllers/record_spec.rb

@@ -233,7 +233,7 @@ def build_call_controller(options)
       </Response>
     TWIML
 
-    stub_twiml_request(controller, response: [options.fetch(:twiml), second_response])
+    stub_twiml_request(controller, response: [ options.fetch(:twiml), second_response ])
 
     controller
   end

components/app/spec/support/call_controller_helpers.rb

@@ -57,7 +57,7 @@ def build_fake_call(options = {})
     )
     allow(fake_call).to receive(:answer_time).and_return(
       *Array(
-        options.fetch(:answer_time) { [nil, Time.now] }
+        options.fetch(:answer_time) { [ nil, Time.now ] }
       )
     )
     fake_call

components/app/spec/support/mock_redis.rb

@@ -21,6 +21,7 @@ def message(&)
       end
 
       poll_for_messages
+      foo = [ "bar", "baz" ]
     end
 
     def publish(message)

components/s3_mpeg/app.rb

@@ -31,7 +31,7 @@ def process
     private
 
     def tempfile(extension = nil, &block)
-      Tempfile.create([SecureRandom.uuid, extension].compact, &block)
+      Tempfile.create([ SecureRandom.uuid, extension ].compact, &block)
     end
 
     def convert_file(raw_file, converted_file)

components/services/app/parsers/ecs_event_parser.rb

@@ -73,7 +73,7 @@ def eni_private_ip_details
 
   def private_ip
     return eni_private_ip unless eni_private_ip.nil?
-    return ec2_instance_private_ip unless container_instance_arn.nil?
+    ec2_instance_private_ip unless container_instance_arn.nil?
   end
 
   def public_ip
@@ -119,7 +119,7 @@ def ec2_instance_id
 
   def ec2_instance_details
     @ec2_instance_details ||= ec2_client.describe_instances(
-      instance_ids: [ec2_instance_id]
+      instance_ids: [ ec2_instance_id ]
     ).to_h
   end