Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of callerId for national dialing #294

Merged
merged 2 commits into from
Aug 18, 2023

WIP

c401bde
Select commit
Loading
Failed to load commit list.
Merged

Better handling of callerId for national dialing #294

WIP
c401bde
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 18, 2023 in 0s

94.01% (+0.13%) compared to b562932

View this Pull Request on Codecov

94.01% (+0.13%) compared to b562932

Details

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.13% 🎉

Comparison is base (b562932) 93.87% compared to head (c401bde) 94.01%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #294      +/-   ##
===========================================
+ Coverage    93.87%   94.01%   +0.13%     
===========================================
  Files          102      103       +1     
  Lines         1829     1870      +41     
===========================================
+ Hits          1717     1758      +41     
  Misses         112      112              
Files Changed Coverage Δ
components/app/app/models/call_properties.rb 100.00% <100.00%> (ø)
components/app/app/models/dial_string.rb 100.00% <100.00%> (ø)
components/app/app/models/execute_twiml.rb 96.57% <100.00%> (-0.05%) ⬇️
components/app/app/models/outbound_call.rb 91.66% <100.00%> (+0.75%) ⬆️
components/app/app/models/routing_parameters.rb 100.00% <100.00%> (ø)
components/app/spec/models/dial_string_spec.rb 100.00% <100.00%> (ø)
components/app/spec/models/outbound_call_spec.rb 100.00% <100.00%> (ø)
...ponents/app/spec/models/routing_parameters_spec.rb 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.