Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECR Private for Gateways #751

Merged
merged 13 commits into from
Sep 18, 2024
Merged

ECR Private for Gateways #751

merged 13 commits into from
Sep 18, 2024

Conversation

dwilkie
Copy link
Collaborator

@dwilkie dwilkie commented Sep 17, 2024

Todo

  • Update docker-compose in somleng-project
  • Use secrets for ECR registry

After Deploy

  • Remove old Github Packages
  • Delete old ECR Public Repositories
  • Remove us-east-1 provider in core
  • Add scheduler to cleanup untagged packages

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base (8cb48d0) to head (4da9025).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #751   +/-   ##
========================================
  Coverage    98.54%   98.54%           
========================================
  Files          166      166           
  Lines         2891     2891           
========================================
  Hits          2849     2849           
  Misses          42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dwilkie dwilkie marked this pull request as draft September 17, 2024 15:21
@dwilkie dwilkie marked this pull request as ready for review September 18, 2024 07:06
@dwilkie dwilkie merged commit 022e4a5 into develop Sep 18, 2024
29 checks passed
@dwilkie dwilkie deleted the ecr_private_for_gateways branch September 18, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant