-
-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
I'm more concern about this one. What was the purpose and what should we do with this code ? |
Long time ago... there was a circular dependency between the classification and the media bundle, so I moved most classification stuff from the media bundle to this repo. It was just a POC that no one ever used. |
That was a pain 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, it can be abandoned https://packagist.org/packages/sonata-project/classification-media-bundle/stats
Not sure it's even worth to open an issue like sonata-project/SonataDoctrinePhpcrAdminBundle#600 for this bundle |
The only thing is that next major version of |
Done #178 |
ClassificationBundle is in the require-dev of MediaBundle, and I had to work on it to help @jordisala1991 on Media, so I would say it's still work correctly. |
👍 I don't know how they work TBH, I remembered sonata-project/SonataClassificationBundle#196, so it was just in case the code was useful. |
ClassificationBundle will stay. But it wont be circular dependency anymore. |
Refs: sonata-project/dev-kit#1669