Allow Symfony 7

[jordisala1991]

Subject

I am targeting this branch, because {reason}.

Closes #{put_issue_number_here}.

Changelog

### Added
- Some `Class::newMethod()` to do great stuff

### Changed

### Deprecated

### Removed

### Fixed

### Security

[jordisala1991]

I am not sure why we needed to extend the acl class if this is not using anything from it, do you know @VincentLanglet ?

The acl package is not really compatible with sf 7.0, the aclvoter misses some typehints

Doing this change is bc break. What should we do?

[VincentLanglet]

I have no idea why it was done like this...

But the security-acl was supposed to be SF-7 compatible https://github.com/symfony/security-acl/blob/main/composer.json ; is there somethng to report to symfony ?

[jordisala1991]

Yep, this interface is not ready for SF 7: https://github.com/symfony/security-acl/blob/main/Voter/AclVoter.php, there are no typehints.

[VincentLanglet]

Indeed we need symfony/security-acl#112

[jordisala1991]

The security-acl package is only used here, for an extends that does not really make sense. Unless I am missing something, the only BC break would be if someone tries to instantiate this class (since it is final) or redeclares the dependency injection... but this class is not expected to be construct by anyone else, since it is hook on the security system using the voter tag.

We could remove dep here and implement normal voter interface. The BC break is not really big

If someone uses security-acl, they need to add the bundle, and the component, and configure them on the security yaml.

[VincentLanglet]

There is some ACL-related doc in this bundle like https://github.com/sonata-project/SonataUserBundle/blob/5.x/docs/reference/installation.rst#acl-configuration

I dunno if we extends the AclVoter to decorate it and replacing it in the service injection. :(
But I never used this bundle...

If we don't need ACL here, let's remove it.

[jordisala1991]

security.acl.voter.user_permissions

It could be replacing the service indeed, but AFAIK the service is only declared on the bundle: https://github.com/symfony/acl-bundle/blob/main/src/Resources/config/acl.xml#L25C9-L25C114

So it is not really replacing it, but declaring another one, the name is different.

[VincentLanglet]

Let's try to remove the extends then

[core23]

I've created a PR on the securty-acl bundle that is only waiting to be merged
symfony/security-acl#116