Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyproject.toml - allow higher rich version #147

Merged

Conversation

cshaley
Copy link
Contributor

@cshaley cshaley commented Nov 7, 2023

This pull request makes the following changes:

  • changes rich ^10.10.0 to rich >=10.10.0

(If there are changes to user behavior in general, please make sure to
update the docs, as well)

It relates to the following issue #s:

Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cshaley
Copy link
Contributor Author

cshaley commented Nov 7, 2023

cc @bhamail / @DarthHater please review / merge if appropriate

@rxm7706
Copy link

rxm7706 commented Nov 24, 2023

Hi @bhamail
cc. @madpah @bollwyvl @maarre @gregegg

Could you consider reviewing and merging this PR please.
A new release will enable all of us again with jake !
Thanks & Regards.

Copy link
Contributor

@bhamail bhamail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1.
Also, thanks for being persistent with the reminder pings!

@bhamail bhamail merged commit a70bb1c into sonatype-nexus-community:main Nov 26, 2023
11 checks passed
@rxm7706
Copy link

rxm7706 commented Nov 27, 2023

Thank you @bhamail - It looks like we need an approval to release & publish to pypi.
https://app.circleci.com/pipelines/github/sonatype-nexus-community/jake/1339/workflows/26dbe621-5002-4e92-b56f-8d56795f2767

@bhamail
Copy link
Contributor

bhamail commented Nov 27, 2023

Thank you @bhamail - It looks like we need an approval to release & publish to pypi. https://app.circleci.com/pipelines/github/sonatype-nexus-community/jake/1339/workflows/26dbe621-5002-4e92-b56f-8d56795f2767

Doh! Yes indeed. Button mashed. Fingers crossed.

@cshaley
Copy link
Contributor Author

cshaley commented Nov 30, 2023

@bhamail As I understand, versioning of jake is automated. It looks like the build tried to publish 3.0.1 again, and it failed.

What's the right next step to get jake updated with the new dependency specification?

@bhamail
Copy link
Contributor

bhamail commented Dec 1, 2023

@cshaley I tried manually incrementing the version and doing a manual release. I don't see errors in the build, but I don't see the new release in pypi either. Please ping again if nothing shows up by tomorrow.

@rxm7706
Copy link

rxm7706 commented Dec 1, 2023

@bhamail - looks like no release published on PyPi - https://pypi.org/project/jake/#history or even on github https://github.com/sonatype-nexus-community/jake/releases - the semantic release step - shows no log - but on the prior step - i do see a warning on poetry-lock being out of date. That shouldn't have prevented the release..

https://app.circleci.com/pipelines/github/sonatype-nexus-community/jake/1341/workflows/26a9d3dc-29e4-4a23-9e23-e15f72674a21/jobs/3061

@cshaley
Copy link
Contributor Author

cshaley commented Dec 5, 2023

@bhamail https://app.circleci.com/pipelines/github/sonatype-nexus-community/jake/1342/workflows/fbc35697-a32c-4121-a5e4-7a9049b46ac6/jobs/3072
It looks like it's working, but not showing up in pypi!

I'm thinking the semantic-release publish step is failing silently. It looks like it also failed (not silently) for all attempts to publish jake 3.0.1 - at least the ones in the publish history that I can see eg 1335 and 1340. So I'm not too sure how 3.0.1 got published to pypi unless it was before the visible history on circleci.

@bhamail thoughts on next steps? It looks like we could do semantic-release -v publish or semantic-release -vv publish to get it to output more information.

@cshaley
Copy link
Contributor Author

cshaley commented Dec 7, 2023

@bhamail thanks for taking the next step.

I think I diagnosed it. python-semantic-release has breaking changes in v8.

So two options:

  1. Revert to `pip install "python-semantic-release<8"
  2. Update commands to
semantic-release version
twine upload dist/* 
semantic-release publish

From reading the python-semantic-release docs linked above, I think jake's current process automatically handles version updates (i.e. v7 of semantic-release updates jake's version in github as part of the publish command). So I think we need all three lines above.
Note: this probably means adding twine to the pip install line too. I'll raise a PR with approach 2.

@gregegg
Copy link

gregegg commented Jan 17, 2024

Hi @bhamail cc. @madpah @bollwyvl @maarre @gregegg

Could you consider reviewing and merging this PR please. A new release will enable all of us again with jake ! Thanks & Regards.

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants