Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAI object ACL_TABLE creation failure in sonic kvm dpu #655

Closed
jimmyzhai opened this issue Jan 13, 2025 · 2 comments · Fixed by #657
Closed

SAI object ACL_TABLE creation failure in sonic kvm dpu #655

jimmyzhai opened this issue Jan 13, 2025 · 2 comments · Fixed by #657

Comments

@jimmyzhai
Copy link
Collaborator

By default swss orchagent needs to create a ACL table (Dataplane Telemetry Watchlist table) during init. It will fail since dash libsai still does not implement it.

Related logs:

2025 Jan 10 09:25:17.869204 vlab-01 ERR syncd#syncd_dash: :- asic_handle_generic: failed to create SAI_OBJECT_TYPE_ACL_TABLE SAI_STATUS_NOT_IMPLEMENTED
2025 Jan 10 09:25:17.869257 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: field: SAI_ACL_TABLE_ATTR_FIELD_INNER_DST_IP, value: true
2025 Jan 10 09:25:17.869257 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: field: SAI_ACL_TABLE_ATTR_FIELD_ICMPV6_TYPE, value: true
2025 Jan 10 09:25:17.869257 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: field: SAI_ACL_TABLE_ATTR_FIELD_ICMP_TYPE, value: true
2025 Jan 10 09:25:17.869271 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: field: SAI_ACL_TABLE_ATTR_FIELD_DST_IPV6, value: true
2025 Jan 10 09:25:17.869271 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: field: SAI_ACL_TABLE_ATTR_FIELD_DSCP, value: true
2025 Jan 10 09:25:17.869315 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: field: SAI_ACL_TABLE_ATTR_FIELD_DST_IP, value: true
2025 Jan 10 09:25:17.869360 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: field: SAI_ACL_TABLE_ATTR_FIELD_ACL_IP_TYPE, value: true
2025 Jan 10 09:25:17.869360 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: field: SAI_ACL_TABLE_ATTR_FIELD_ICMPV6_CODE, value: true
2025 Jan 10 09:25:17.869410 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: field: SAI_ACL_TABLE_ATTR_FIELD_ETHER_TYPE, value: true
2025 Jan 10 09:25:17.869410 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: field: SAI_ACL_TABLE_ATTR_ACL_ACTION_TYPE_LIST, value: 6:SAI_ACL_ACTION_TYPE_ACL_DTEL_FLOW_OP,SAI_ACL_ACTION_TYPE_DTEL_INT_SESSION,SAI_ACL_ACTION_TYPE_DTEL_DROP_REPORT_ENABLE,SAI_ACL_ACTION_TYPE_DTEL_TAIL_DROP_REPORT_ENABLE,SAI_ACL_ACTION_TYPE_DTEL_FLOW_SAMPLE_PERCENT,SAI_ACL_ACTION_TYPE_DTEL_REPORT_ALL_PACKETS
2025 Jan 10 09:25:17.869445 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: field: SAI_ACL_TABLE_ATTR_FIELD_TUNNEL_VNI, value: true
2025 Jan 10 09:25:17.869445 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: field: SAI_ACL_TABLE_ATTR_FIELD_SRC_IPV6, value: true
2025 Jan 10 09:25:17.869477 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: field: SAI_ACL_TABLE_ATTR_FIELD_INNER_ETHER_TYPE, value: true
2025 Jan 10 09:25:17.869477 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: field: SAI_ACL_TABLE_ATTR_ACL_BIND_POINT_TYPE_LIST, value: 1:SAI_ACL_BIND_POINT_TYPE_SWITCH
2025 Jan 10 09:25:17.869527 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: field: SAI_ACL_TABLE_ATTR_FIELD_SRC_IP, value: true
2025 Jan 10 09:25:17.869544 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: field: SAI_ACL_TABLE_ATTR_FIELD_TCP_FLAGS, value: true
2025 Jan 10 09:25:17.869544 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: field: SAI_ACL_TABLE_ATTR_ACL_STAGE, value: SAI_ACL_STAGE_INGRESS
2025 Jan 10 09:25:17.869553 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: field: SAI_ACL_TABLE_ATTR_FIELD_L4_DST_PORT, value: true
2025 Jan 10 09:25:17.869584 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: field: SAI_ACL_TABLE_ATTR_FIELD_OUTER_VLAN_ID, value: true
2025 Jan 10 09:25:17.869584 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: field: SAI_ACL_TABLE_ATTR_FIELD_ICMP_CODE, value: true
2025 Jan 10 09:25:17.869627 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: field: SAI_ACL_TABLE_ATTR_FIELD_L4_SRC_PORT, value: true
2025 Jan 10 09:25:17.869627 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: field: SAI_ACL_TABLE_ATTR_FIELD_INNER_SRC_IP, value: true
2025 Jan 10 09:25:17.869627 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: field: SAI_ACL_TABLE_ATTR_FIELD_IP_PROTOCOL, value: true
2025 Jan 10 09:25:17.869672 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: field: SAI_ACL_TABLE_ATTR_FIELD_IPV6_NEXT_HEADER, value: true
2025 Jan 10 09:25:17.869672 vlab-01 ERR syncd#syncd_dash: :- asic_process_event: failed to execute api: create, key: SAI_OBJECT_TYPE_ACL_TABLE:oid:0x700000000000d, status: SAI_STATUS_NOT_IMPLEMENTED
2025 Jan 10 09:25:17.869709 vlab-01 NOTICE syncd#syncd_dash: :- executeOperationsOnAsic: asic apply took 0.001885 sec
2025 Jan 10 09:25:17.869709 vlab-01 ERR syncd#syncd_dash: :- executeOperationsOnAsic: Error while executing asic operations, ASIC is in inconsistent state: :- asic_process_event: failed to execute api: create, key: SAI_OBJECT_TYPE_ACL_TABLE:oid:0x700000000000d, status: SAI_STATUS_NOT_IMPLEMENTED
2025 Jan 10 09:25:17.869740 vlab-01 NOTICE syncd#syncd_dash: :- applyView: apply took 0.004734 sec
2025 Jan 10 09:25:17.869740 vlab-01 ERR syncd#syncd_dash: :- run: Runtime error: :- asic_process_event: failed to execute api: create, key: SAI_OBJECT_TYPE_ACL_TABLE:oid:0x700000000000d, status: SAI_STATUS_NOT_IMPLEMENTED
@jimmyzhai jimmyzhai mentioned this issue Jan 13, 2025
Merged
@KrisNey-MSFT
Copy link
Collaborator

hi @jimmyzhai - are we looking to merge this one; do we need a reviewer?

@jimmyzhai
Copy link
Collaborator Author

jimmyzhai commented Jan 16, 2025 •
edited
Loading

hi @jimmyzhai - are we looking to merge this one; do we need a reviewer?

Yes, looks @r12f and @kcudnik are reviewing PR #657

@r12f r12f closed this as completed in #657 Jan 17, 2025
r12f pushed a commit that referenced this issue Jan 17, 2025
@jimmyzhai
[libsai] dummy implementation for ACL_TABLE (#657)
f5b4b70 
1. Fix #655 , by adding dummy implementation for
SAI_OBJECT_TYPE_ACL_TABLE
2. Fix #656, by bypassing creation of route entry with prefix length 0
@KrisNey-MSFT KrisNey-MSFT mentioned this issue Feb 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[libsai] dummy implementation for ACL_TABLE jimmyzhai/DASH
2 participants
@jimmyzhai @KrisNey-MSFT