[libsai] dummy implementation for ACL_TABLE #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jimmyzhai
commented
Jan 13, 2025
jimmyzhai
commented
- Fix SAI object ACL_TABLE creation failure in sonic kvm dpu #655 , by adding dummy implementation for SAI_OBJECT_TYPE_ACL_TABLE
- Fix Default IPv6 route ::/0 not support in dash pipeline #656, by bypassing creation of route entry with prefix length 0
|
/azp run |
|
Commenter does not have sufficient privileges for PR 657 in repo sonic-net/DASH |
kcudnik
reviewed
Jan 15, 2025
|
/azp run |
|
Commenter does not have sufficient privileges for PR 657 in repo sonic-net/DASH |
Updated the comment for the bypass reason: return SAI_STATUS_SUCCESS; // bypass, temporary workaround for issue #656 |
This was referenced Jan 16, 2025
r12f
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.