Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address coments from review of HA proposal #271

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions documentation/high-avail/AMD-Pensando_HA_Proposal.md
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,11 @@ typedef enum _sai_dash_ha_rewrite_flags_t {
*
*/
typedef struct _sai_dash_ha_rewrite_info_t {
/**
* @brief Flow Rewrite Flags expressed as a bit map of sai_dash_ha_rewrite_flags_t
*/
sai_uint64_t rewrite_flags;

/**
* @brief Initiator Flow DMAC
*/
Expand All @@ -401,11 +406,6 @@ typedef struct _sai_dash_ha_rewrite_info_t {
*/
sai_uint32_t iflow_vni;

/**
* @brief Initiator Flow Rewrite Flags expressed as a bit map of sai_dash_ha_rewrite_flags_t
*/
sai_uint16_t iflow_flags;

/**
* @brief Reverse Flow Source IP address
*/
Expand All @@ -429,12 +429,7 @@ typedef struct _sai_dash_ha_rewrite_info_t {
/**
* @brief Reverse Flow VNID
*/
sai_uint32_t iflow_vni;

/**
* @brief Reverse Flow Rewrite Flags expressed as a bit map of sai_dash_ha_rewrite_flags_t
*/
sai_uint16_t iflow_flags;
sai_uint32_t rflow_vni;
} sai_dash_ha_rewrite_info_t;

/**
Expand All @@ -456,7 +451,7 @@ typedef struct _sai_dash_ha_flow_sync_message_metadata_t {
/**
* @brief ID of metering class to be used
*/
sai_object_id_t meetering_class;
sai_uint64_t meetering_class;
SanjayTh marked this conversation as resolved.
Show resolved Hide resolved

/**
* @brief Rewrite information for the flow
Expand Down