Add per ENI DSCP setting #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marian-pritsak
force-pushed
the
dscp
branch
6 times, most recently
from
707f41e to
af09c2b
Compare
By default, use DSCP from the original outer packet. Signed-off-by: Marian Pritsak <[email protected]>
r12f
reviewed
Oct 10, 2023
r12f
reviewed
Oct 11, 2023
dash-pipeline/bmv2/dash_pipeline.p4
Outdated
| @@ -116,6 +116,8 @@ control dash_ingress( | |||
| bit<16> vnet_id, | |||
| bit<16> v4_meter_policy_id, | |||
| bit<16> v6_meter_policy_id, | |||
| dash_tunnel_dscp_mode_t dash_tunnel_dscp_mode, | |||
There was a problem hiding this comment.
feels like we can simply call it tunnel_dscp_mode
There was a problem hiding this comment.
and to make things match the dscp field can be tunnel_dscp_value.
|
hi @marian-pritsak - is this ready for a Merge? Let me know :) |
|
hi @marian-pritsak - checking to see if you'd like to try to merge this one, this week? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, use DSCP from the original outer packet.