Update SAI to include the appliance local region id change. #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Commenter does not have sufficient privileges for PR 641 in repo sonic-net/DASH |
mukeshmv
approved these changes
Nov 8, 2024
|
@mgheorghe perhaps to take a look |
|
hi @mukeshmv - is this one ready to go? TY! |
|
yes @KrisNey-MSFT, this can be merged |
|
@r12f do you know who would make sure the checks pass? Mukesh said it is ok to merge, but it is failing CI |
|
Failing PTF test check:
|
|
Existing attribute in SAI becomes removed; needs bounceback IP |
|
Send email to Mukesh, Senthil, Riff. |
|
Yea, @jimmyzhai made a new PR for SAI update, so maybe we can close this one. : D |
|
Closing as duplicate per Riff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the SAI reference to the latest.