Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build]: Fix marvell sai package version parsing issue #10009

Merged
merged 1 commit into from
Feb 19, 2022

Conversation

xumia
Copy link
Collaborator

@xumia xumia commented Feb 17, 2022

Why I did it

Fix marvell build break issue, see below:

buildId jobName attempt startTime branchName reason url
70560 marvell_armhf 1 2022-02-07 07:20:06.9566667 202012 pullRequest https://dev.azure.com/mssonic/build/_build/results?buildId=70560
71680 marvell_armhf 1 2022-02-11 04:00:26.0200000 202012 schedule https://dev.azure.com/mssonic/build/_build/results?buildId=71680
71726 marvell_armhf 1 2022-02-11 07:18:33.1366667 202012 manual https://dev.azure.com/mssonic/build/_build/results?buildId=71726
71779 marvell_armhf 1 2022-02-11 08:21:08.3266667 202012 manual https://dev.azure.com/mssonic/build/_build/results?buildId=71779
71780 marvell_armhf 1 2022-02-11 08:21:25.0600000 202012 manual https://dev.azure.com/mssonic/build/_build/results?buildId=71780
72100 marvell_armhf 2 2022-02-14 07:33:53.4200000 202012 schedule https://dev.azure.com/mssonic/build/_build/results?buildId=72100

How I did it

Change the marvell sai package to the standard format, see Marvell-switching/sonic-marvell-binaries#62

<PackageName>_<VersionNumber>-<DebianRevisionNumber>_<DebianArchitecture>.deb

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Copy link
Collaborator

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Suggest also check with MRVL SAI owner.

@xumia xumia merged commit f65a071 into sonic-net:master Feb 19, 2022
@xumia xumia deleted the fix-marvell-sai-package branch February 19, 2022 04:16
xumia added a commit that referenced this pull request Feb 19, 2022
Fix marvell sai package version parsing issue (#10009)
xumia added a commit that referenced this pull request Feb 19, 2022
Fix marvell sai package version parsing issue (#10009)
xumia added a commit that referenced this pull request Feb 19, 2022
Fix marvell sai package version parsing issue (#10009)
@xumia xumia added Included in 202111 Branch and removed Request for 202111 Branch For PRs being requested for 202111 branch labels Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants