Multiprocessing Manager resources (Queue) to be freed up during task stop #15212
Conversation
|
@adyeung @Junchao-Mellanox @vaibhavhd |
| self.mpmgr.shutdown() | ||
|
|
||
| # Wait for the process to exit | ||
| self._task_process.join(self._stop_timeout_secs) |
There was a problem hiding this comment.
should monitor_system_bus task and monitor_statedb_table task be join here?
There was a problem hiding this comment.
At the end of the system_service() function, there exists a call to monitor_system_bus.task_stop() and monitor_statedb_table.task_stop(), which are responsible for shutting down their respective tasks.
| if self._task_process.is_alive(): | ||
| os.kill(self._task_process.pid, signal.SIGKILL) | ||
|
|
||
| if self._task_process.is_alive(): |
There was a problem hiding this comment.
log something here?
Multiprocessing Manager resources (Queue) to be freed up during task stop
sg893052
force-pushed
the
sysready_buf_fix
branch
from
f72ab1c
to
b3ae16c
Compare
bingwang-ms
added
Request for 202111 Branch
|
@Junchao-Mellanox Can you please check and review? Thanks |
|
@Junchao-Mellanox please check the latest comments here. We need to take this fix in sooner. @sg893052, please update the test description to indicate that the shutdown path is no longer hung/delayed. Please test that path if not already tested. |
|
ADO: 22090981 |
qiluo-msft
changed the title
|
@sg893052 PR conflicts with 202211 branch |
yxieca
added
Request for 202211 Branch
and removed
Request for 202111 Branch
yxieca
added
Approved for 202205 Branch
and removed
Approved for 202205 Branch
Approved for 202211 Branch
labels
|
@sg893052 PR conflicts with 202205 branch |
|
@sg893052 please help create separate PR for 202205/202211 branches. Thanks! |
|
Cherry-pick PR to 202305: #15595 |
Multiprocessing Manager resources (Queue) to be freed up during task stop
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
|
@sg893052 PR conflicts with 202205 branch |
Multiprocessing Manager resources (Queue) to be freed up during task stop
Multiprocessing Manager resources (Queue) to be freed up during task stop
Why I did it
Fix for issue #14964
Work item tracking
How I did it
Free up Multiprocessing Manager resource at task stop request
[self.mpmgr.shutdown() in task_stop]
How to verify it
time systemctl stop system-health.service
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)