Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202012] [TACACS+] Add audisp-tacplus for per-command accounting. (#8750) #15788

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

liuh-80
Copy link
Contributor

@liuh-80 liuh-80 commented Jul 11, 2023

This pull request integrate audisp-tacplus to SONiC for per-command accounting.

Backport: #8750

Work item tracking
  • Microsoft ADO (number only): 24433713

Why I did it

To support TACACS per-command accounting, we integrate audisp-tacplus project to sonic.

How I did it

  1. Add auditd service to SONiC
  2. Port and patch audisp-tacplus to SONiC

How to verify it

UT with CUnit to cover all new code in usersecret-filter.c
Also pass all current UT.

Which release branch to backport (provide reason below if selected)

N/A

Tested branch (Please provide the tested image version)

Extract tacacs support functions into library, this will share TACACS config file parse code with other project.
Also fix memory leak issue in parse config code.

  • SONiC.202012-15723.312602-e230e2d3e

Description for the changelog

Add audisp-tacplus for per-command accounting.

A picture of a cute animal (not mandatory but encouraged)

liuh-80 and others added 2 commits July 11, 2023 05:51
)

This pull request integrate audisp-tacplus to SONiC for per-command accounting.

To support TACACS per-command accounting, we integrate audisp-tacplus project to sonic.

1. Add auditd service to SONiC
2. Port and patch audisp-tacplus to SONiC

UT with CUnit to cover all new code in usersecret-filter.c
Also pass all current UT.

N/A

Add audisp-tacplus for per-command accounting.
@liuh-80 liuh-80 marked this pull request as ready for review July 12, 2023 08:09
@qiluo-msft qiluo-msft merged commit 4df2bc9 into sonic-net:202012 Jul 13, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants