[eventd] Fix eventd UT flakiness #17055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azpw ms_conflict |
1 similar comment
|
/azpw ms_conflict |
ganglyu
reviewed
Nov 9, 2023
ganglyu
approved these changes
Nov 21, 2023
|
@StormLiangMS Can you please review? I have tested this issue on official build pipeline and I am no longer seeing any flakiness in 12+ consecutive runs. |
qiluo-msft
reviewed
Dec 2, 2023
src/sonic-eventd/tests/eventd_ut.cpp
Outdated
| @@ -625,7 +632,7 @@ TEST(eventd, service) | |||
| run_pub(mock_pub, wr_source, wr_evts); | |||
|
|
|||
| /* Published events must have been captured. Give a pause, to ensure sent. */ | |||
| this_thread::sleep_for(chrono::milliseconds(200)); | |||
| this_thread::sleep_for(chrono::milliseconds(1000)); | |||
There was a problem hiding this comment.
ZMQ is async. No signal indication. It silently drops when not good.
qiluo-msft
reviewed
Jan 31, 2024
src/sonic-eventd/tests/eventd_ut.cpp
Outdated
|
|
||
| while(true) { | ||
| auto current_ts = chrono::steady_clock::now(); | ||
| if(chrono::duration_cast<chrono::milliseconds>(current_ts - poll_start_ts).count() >= max_polling_duration) { |
There was a problem hiding this comment.
[](http://example.com/codeflow?start=0&length=5)
Mix using tabs (several lines in the new code) and spaces. #Closed
qiluo-msft
previously approved these changes
Jan 31, 2024
qiluo-msft
approved these changes
Feb 13, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Feb 16, 2024
### Why I did it Fix flakiness of eventd UT - run sub after capture service starts ##### Work item tracking - Microsoft ADO **(number only)**:25650744 #### How I did it Run sub socket after capture socket is initialized #### How to verify it Pipeline
|
Cherry-pick PR to 202311: #18111 |
mssonicbld
pushed a commit
that referenced
this pull request
Feb 19, 2024
### Why I did it Fix flakiness of eventd UT - run sub after capture service starts ##### Work item tracking - Microsoft ADO **(number only)**:25650744 #### How I did it Run sub socket after capture socket is initialized #### How to verify it Pipeline
StormLiangMS
added
Approved for 202305 Branch
and removed
Approved for 202305 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Mar 4, 2024
### Why I did it Fix flakiness of eventd UT - run sub after capture service starts ##### Work item tracking - Microsoft ADO **(number only)**:25650744 #### How I did it Run sub socket after capture socket is initialized #### How to verify it Pipeline
|
Cherry-pick PR to 202305: #18249 |
mssonicbld
pushed a commit
that referenced
this pull request
Mar 4, 2024
### Why I did it Fix flakiness of eventd UT - run sub after capture service starts ##### Work item tracking - Microsoft ADO **(number only)**:25650744 #### How I did it Run sub socket after capture socket is initialized #### How to verify it Pipeline
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
liushilongbuaa
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
sonic-otn
pushed a commit
to Weitang-Zheng/sonic-buildimage
that referenced
this pull request
Mar 11, 2024
### Why I did it Fix flakiness of eventd UT - run sub after capture service starts ##### Work item tracking - Microsoft ADO **(number only)**:25650744 #### How I did it Run sub socket after capture socket is initialized #### How to verify it Pipeline
saksarav-nokia
pushed a commit
to saksarav-nokia/sonic-buildimage
that referenced
this pull request
Mar 12, 2024
### Why I did it Fix flakiness of eventd UT - run sub after capture service starts ##### Work item tracking - Microsoft ADO **(number only)**:25650744 #### How I did it Run sub socket after capture socket is initialized #### How to verify it Pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix flakiness of eventd UT - run sub after capture service starts
Work item tracking
How I did it
Run sub socket after capture socket is initialized
How to verify it
Pipeline
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)