Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:17749] [TACACS] Fix when set TACACS to "tacacs+, local" user can run blocked command with local permission issue. #17944

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

mssonicbld
Copy link
Collaborator

Fix when set TACACS to "tacacs+, local" user can run blocked command with local permission issue.

Why I did it

When set TACACS to "tacacs+, local", user still can run a blocked command with local permission.

Work item tracking
  • Microsoft ADO: 26399545

How I did it

Fix code to reject command when authorized failed from TACACS server side.

How to verify it

Pass all UT.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

  • SONiC.master-17749.460496-3414b9841
  • SONiC.202205.459917-1239ef1d8

Description for the changelog

Fix when set TACACS to "tacacs+, local" user can run blocked command with local permission issue.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

… command with local permission issue. (sonic-net#17749)

Fix when set TACACS to "tacacs+, local" user can run blocked command with local permission issue.

#### Why I did it
When set TACACS to "tacacs+, local", user still can run a blocked command with local permission.

##### Work item tracking
- Microsoft ADO: 26399545

#### How I did it
Fix code to reject command when authorized failed from TACACS server side.

#### How to verify it
Pass all UT.

### Description for the changelog
Fix when set TACACS to "tacacs+, local" user can run blocked command with local permission issue.
@mssonicbld
Copy link
Collaborator Author

Original PR: #17749

@mssonicbld mssonicbld merged commit c5086a0 into sonic-net:202305 Jan 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants