Go Code format checker and formatter #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faraazbrcm
force-pushed
the
master
branch
4 times, most recently
from
5f11925 to
f59552f
Compare
|
It is good to bypass the coverage check for only the format change. |
|
Yes I support that..
Can admin help me forcing merging this change as it has passed all checks
except coverage?
…On Tue, 14 Nov, 2023, 3:57 pm xumia, ***@***.***> wrote:
It is good to bypass the coverage check for only the format change.
—
Reply to this email directly, view it on GitHub
<#171 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMN6I5NVI5FI7LOSOMIHPATYENBRRAVCNFSM6AAAAAA6V4FX6SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBZHEZTMMZRGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
This electronic communication and the information and any files transmitted
with it, or attached to it, are confidential and are intended solely for
the use of the individual or entity to whom it is addressed and may contain
information that is confidential, legally privileged, protected by privacy
laws, or otherwise restricted from disclosure to anyone else. If you are
not the intended recipient or the person responsible for delivering the
e-mail to the intended recipient, you are hereby notified that any use,
copying, distributing, dissemination, forwarding, printing, or copying of
this e-mail is strictly prohibited. If you received this e-mail in error,
please return the e-mail to the sender, delete it from your computer, and
destroy any printed copy of it.
|
kwangsuk
reviewed
Nov 14, 2023
Makefile
Outdated
| FORMAT_CHECK = $(BUILD_DIR)/.formatcheck | ||
| FORMAT_LOG = $(BUILD_DIR)/go_format.log | ||
| # Find all .go files excluding vendor, build, and patches files | ||
| GO_FILES := $(shell find . -type f -name '*.go' ! -path './vendor/*' ! -path './build/*' ! -path './patches/*' ! -path './proto/*') |
There was a problem hiding this comment.
In case of swsscommon, the go file is auto-generated by a foolproof swig tool, which does not require rigorous go formatting. So, can you add 'swsscommon/*' to the excluded paths?
kwangsuk
reviewed
Nov 14, 2023
faraazbrcm
force-pushed
the
master
branch
3 times, most recently
from
9c8edca to
6aa548d
Compare
faraazbrcm
force-pushed
the
master
branch
2 times, most recently
from
5a3c710 to
88f5ece
Compare
Also formatted the files which dont adhere to go formats. Build will fail if there exists any formatting issue
|
Replaced with #182 as it supports formatting using Bookworm's Golang version(go1.19) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also formatted the files which dont adhere to go formats. Build will fail if there exists any formatting issue