Let pfcwdmap creation fail gracefully #207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
Mar 30, 2024
sonic_data_client/virtual_db.go
Outdated
|
|
||
| var qos_key string | ||
| for _, key := range resp { | ||
| if strings.Contains(key, "Ethernet") { // Account for PORT_QOS_MAP|global |
There was a problem hiding this comment.
I understand this is to filter all key containing "Ethernet". However this prefix may be changed in future. Check not equal to "global" may be safer.
rlucus
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADO: 27075747
Why I did it
There is a chance that PORT_QOS_MAP|global is used to fetc pfc_enable key, which will cause redis hget to fail and return err. All queries to counters_db will fail after that.
How I did it
Iterate and not use global as key for port_qos_map to check for pfc_enable
Any error creating pfcwd map will not stop future COUNTERS_DB queries
How to verify it
UT/Manual test. Tested in 202305
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)