Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE -- Building 202305 with Cert Rotation feature #215

Draft
wants to merge 4 commits into
base: 202305
Choose a base branch
from

Conversation

zbud-msft
Copy link
Contributor

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Telemetry Process will now no longer exit when certs are missing. Because we added a goroutine within startGNMIServer such that we create a fsnotify watcher on the certificates directory to monitor changes brought upon files within that directory, such as deletion, creation, and modification, we will wait for certs to be present and then start gnmi server to start serving.
@zbud-msft zbud-msft requested a review from qiluo-msft April 11, 2024 01:09
@qiluo-msft
Copy link
Collaborator

qiluo-msft commented Apr 11, 2024

Which master commits are you trying to backport?

d8d15c7 736e3b4 758ec18 feaa1df

I won't be backporting these commits. This is just for building an official telemetry binary with these changes for 202305 image.

@qiluo-msft qiluo-msft marked this pull request as draft April 11, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants