DBUS API for Containerz.StopContainer #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Nov 15, 2024
| MOD_NAME = "docker_service" | ||
|
|
||
|
|
||
| class DockerService(host_service.HostModule): |
There was a problem hiding this comment.
We could do that. But eventually we still need a docker service for upgrade because even if we can stop the old container using systemd, launching new container with new image:tag still requires a docker run command (correct me if I am wrong) which still requires this docker service.
If that's so we might as well let this relatively simple code in and build on top of it.
There was a problem hiding this comment.
Agree with docker service vs systemd service. I feel there is value in ALLOWED_SERVICES. Could you reuse that array or implemnet a similar ALLOWED_CONTAINERS.
qiluo-msft
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DBUS API for Containerz.StopContainer