Marvell Armhf support and Arm64 support #125
Conversation
Adding support to compile ARM architecture (sonic-net#102) 2. Added support for marvell Armada A7020 Arm64 Signed-off-by: Antony Rheneus <[email protected]>
| Date: Mon, 26 Aug 2019 13:43:39 +0300 | ||
| Subject: [PATCH 4/6] ARM64/PCI: Allow userspace to mmap PCI resources | ||
|
|
||
| Change-Id: I87ef6492e4956c77c75470ec010a4f11a9a8bdaf |
There was a problem hiding this comment.
is this back port? if yes, what is original commit id in linux kernel tree?
There was a problem hiding this comment.
No, this is not a backport, For arm64 this change is been circulated in the kernel forum and still not taken.
https://lore.kernel.org/patchwork/patch/770393/
|
please identify the upstream commit id and the start linux version that introduce this patch. check below for example |
Adding support to compile ARM architecture (sonic-net#102) 2. Added support for marvell Armada A7020 Arm64 Signed-off-by: Antony Rheneus <[email protected]>
|
this patch. patch/0001-Marvell-support-for-armada7020-on-LK4.9.168.patch what is the nature? is it upstreamed? How could we maintain this patch? also, I do not see this patch in master branch. |
Armada 7020 support got upstreamed. Im also thinking how to maintain it, as it would break future kernel version migration. |
There was a problem hiding this comment.
Are you planning on updating the merge/pull request? Please also update the commit messages of the two commits. Currently they have the same message, and are not written and formatted according to common guidelines.
| # CONFIG_MTD_TESTS is not set | ||
| # CONFIG_MTD_REDBOOT_PARTS is not set | ||
| -# CONFIG_MTD_CMDLINE_PARTS is not set | ||
| +CONFIG_MTD_CMDLINE_PARTS=y |
There was a problem hiding this comment.
Please add to the commit message of this patch patch/0042-armhf-additional-configs.patch, for what these options are needed.
| Date: Mon, 26 Aug 2019 14:58:10 +0300 | ||
| Subject: [PATCH 5/6] add a7020-comexp dts | ||
|
|
||
| Change-Id: If4d6e2b704aad1616ad91871282e678eabb400dd |
There was a problem hiding this comment.
If this has been sent upstream, please add the URL or git hash in the Linux repository.
| Date: Mon, 22 Jul 2019 13:44:06 +0300 | ||
| Subject: [PATCH 1/4] Micron 4G flash support | ||
|
|
||
| Change-Id: Ib4dd7094920c124c213f6b3c81140845e5baa084 |
There was a problem hiding this comment.
If this has been sent upstream, please add the URL or git hash in the Linux repository.
| From: Antony Rheneus <[email protected]> | ||
| Date: Thu, 17 Oct 2019 18:31:57 +0530 | ||
| Subject: [PATCH] arm64 default config for sonic patches | ||
|
|
There was a problem hiding this comment.
Please elaborate. Currently it looks like, only make olddefconfig was run against a newer Linux kernel version. This could be split out into a separate merge/pull request, couldn’t it be?
There was a problem hiding this comment.
Yes, the patch approach for kernel config is obsolete in current master branch,
This PR has to be revisited and the required changes should go into patch/kconfig_inclusion and patch/kconfig_exclusion.
Thanks for your time to review this PR.
Action Item would be to raise a as per new manage_kernel_config infra.
|
/easycla |
Back ported commit from master
Adding support to compile ARM architecture (Adding support to compile ARM architecture #102)
Added support for marvell Armada A7020 Arm64
Signed-off-by: Antony Rheneus [email protected]