Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query parameters enhancements in rest-server. #119

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Query parameters enhancements in rest-server. #119

merged 4 commits into from
Oct 6, 2023

Conversation

ranjinidn
Copy link
Contributor

@ranjinidn ranjinidn commented Sep 11, 2023 •
edited
Loading

Add support for following standard REST query-parameters for GET operation(https://datatracker.ietf.org/doc/html/rfc8040#section-4.8) :

depth : used to limit the depth of subtrees retrieved for a given GET request.
content : used to retrieve config and/or non-config descendant nodes of requested target in a GET request.
fields : used to retrieve specific subset of data nodes within the target for a GET request.

Verification done using unit tests and added new cases for above.
Unit test run results are part of pipeline test run.

Has build dependency on the below PR
sonic-net/sonic-mgmt-common#102
Both the PRs needs to be merged together to support the query parameters enhancement

@a-barboza
Copy link
Contributor

Has build dependency on the below PR
sonic-net/sonic-mgmt-common#102
Both the PRs needs to be merged together to support the query parameters enhancement

@a-barboza a-barboza mentioned this pull request Sep 16, 2023
Merged
@ebiken-ntt ebiken-ntt mentioned this pull request Sep 21, 2023
Open
@ranjinidn ranjinidn closed this Sep 27, 2023
@ranjinidn ranjinidn reopened this Sep 27, 2023
@ranjinidn
Copy link
Contributor Author

Closing PR and reopening PR to trigger new build

@ranjinidn ranjinidn closed this Sep 27, 2023
@ranjinidn ranjinidn reopened this Sep 27, 2023
@ranjinidn ranjinidn force-pushed the restserver_query_params_enhacements branch 2 times, most recently from fe19fb3 to 226e79a Compare September 27, 2023 23:54
@sachinholla sachinholla mentioned this pull request Sep 28, 2023
Closed
@ranjinidn ranjinidn force-pushed the restserver_query_params_enhacements branch from f94583e to 226e79a Compare September 28, 2023 17:06
@jeff-yin
Copy link

jeff-yin commented Oct 2, 2023 •
edited
Loading

@anand-kumar-subramanian @tomek-US -- please review/approve/merge this PR
It needs to go with sonic-net/sonic-mgmt-common#102, which has been merged.

@anand-kumar-subramanian anand-kumar-subramanian merged commit dfac87c into sonic-net:master Oct 6, 2023
4 checks passed
@adyeung adyeung mentioned this pull request Oct 12, 2023
Closed
@liushilongbuaa
Copy link
Contributor

@ranjinidn , submodule update PR failed.
sonic-net/sonic-buildimage#16792

@ranjinidn
Copy link
Contributor Author

@ranjinidn , submodule update PR failed. sonic-net/sonic-buildimage#16792

This PR in sonic-mgmt-common - sonic-net/sonic-mgmt-common#102
should go in together with the PR in sonic-mgmt-framework PR #119
since they have build dependency.

@liushilongbuaa
Copy link
Contributor

@ranjinidn , submodule update PR failed. sonic-net/sonic-buildimage#16792

This PR in sonic-mgmt-common - sonic-net/sonic-mgmt-common#102 should go in together with the PR in sonic-mgmt-framework PR #119 since they have build dependency.

Can you create a PR to update both submodules?

@ranjinidn ranjinidn mentioned this pull request Oct 31, 2023
Merged
@ranjinidn
Copy link
Contributor Author

@ranjinidn , submodule update PR failed. sonic-net/sonic-buildimage#16792

This PR in sonic-mgmt-common - sonic-net/sonic-mgmt-common#102 should go in together with the PR in sonic-mgmt-framework PR #119 since they have build dependency.

Can you create a PR to update both submodules?

PR has been raised. Please review. sonic-net/sonic-buildimage#17054

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anand-kumar-subramanian anand-kumar-subramanian anand-kumar-subramanian approved these changes

@a-barboza a-barboza a-barboza approved these changes

@kwangsuk kwangsuk kwangsuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ranjinidn @a-barboza @jeff-yin @liushilongbuaa @kwangsuk @anand-kumar-subramanian