Skip to content

Commit

Permalink
chore: toggle plt_reboot_ctrl_overwrite to increase timeout for t2 (#…
Browse files Browse the repository at this point in the history
…15951)

Description of PR
Summary:
Fixes # (issue) 3045798

The decision was to enable this test gap in #13476 however we mentioned that we need to increase the time.

By default, the reboot time will be decided from constant variable reboot_ctrl_dict which will set the REBOOT_TYPE_COLD = 300

https://github.com/sonic-net/sonic-mgmt/blob/master/tests/common/reboot.py#L133

For T2, this time is not sufficient enough and lead to failure. We will adjust the time accordingly.

This PR will fix that

Approach
What is the motivation for this PR?
How did you do it?
Enable plt_reboot_ctrl_overwrite if platform is T2

Signed-off-by: Austin Pham <[email protected]>
  • Loading branch information
auspham authored Dec 11, 2024
1 parent b16729e commit 12caaa8
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion tests/platform_tests/test_reload_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def test_reload_configuration(duthosts, enum_rand_one_per_hwsku_hostname,

logging.info("Wait some time for all the transceivers to be detected")
max_wait_time_for_transceivers = 300
if duthost.facts["platform"] == "x86_64-cel_e1031-r0":
if duthost.facts["platform"] in ["x86_64-cel_e1031-r0", "x86_64-88_lc0_36fh_m-r0"]:
max_wait_time_for_transceivers = 900
assert wait_until(max_wait_time_for_transceivers, 20, 0, check_all_interface_information,
duthost, interfaces, xcvr_skip_list), "Not all transceivers are detected \
Expand Down Expand Up @@ -158,7 +158,12 @@ def test_reload_configuration_checks(duthosts, enum_rand_one_per_hwsku_hostname,
if not config_force_option_supported(duthost):
return

timeout = None
if duthost.get_facts().get("modular_chassis"):
timeout = 420

reboot(duthost, localhost, reboot_type="cold", wait=5,
timeout=timeout,
plt_reboot_ctrl_overwrite=False)

# Check if all database containers have started
Expand Down

0 comments on commit 12caaa8

Please sign in to comment.