Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip SNMP IPv6 testcases in 2022xx 2023xx branches #10097

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Skip SNMP IPv6 testcases in 2022xx 2023xx branches #10097

merged 3 commits into from
Sep 28, 2023

Conversation

SuvarnaMeenakshi
Copy link
Contributor

@SuvarnaMeenakshi SuvarnaMeenakshi commented Sep 21, 2023 •
edited
Loading

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

Skip SNMP IPv6 related test cases in 202211,202205 and 202305 branches until the approach to fix IPv6 issue is fixed.
PR contains details of the issue and approach sonic-net/SONiC#1457

How did you do it?

Skip single asic IPv6 SNMP loopback test case and link local test case in branches with the testcase added.

How did you verify/test it?

Tested on 202205 single asic VS image:

snmp/test_snmp_loopback.py::test_snmp_loopback[vlab-01-IPv4Address] PASSED                                              [ 50%]
snmp/test_snmp_loopback.py::test_snmp_loopback[vlab-01-IPv6Address] SKIPPED                                             [100%]

----------------------------------- generated xml file: /data/sonic-mgmt/tests/logs/tr.xml ------------------------------------
=================================================== short test summary info ===================================================
SKIPPED [1] /data/sonic-mgmt/tests/common/utilities.py:67: DUT has version 202205.368253-4ee956506 and test does not support 202211, 202205, 202305
============================================ 1 passed, 1 skipped in 23.30 seconds =============================================
INFO:root:Can not get Allure report URL. Please check logs

test_snmp_link_local.py:

./run_tests.sh -n vms-kvm-t0 -d vlab-01 -c snmp/test_snmp_link_local.py -f vtestbed.yaml -i ../ansible/veos_vtb -e "--skip_sanity --disable_loganalyzer" -e "--mark-conditions-files common/plugins/conditional_mark/tests_mark_conditions.yaml" -u -e "--rootdir /data/sonic-mgmt/tests"

SKIPPED [1] snmp/test_snmp_link_local.py:19: SNMP over IPv6 support not present in release branches.
=========================================== 1 skipped, 1 warnings in 15.98 seconds ============================================
INFO:root:Can not get Allure report URL. Please check logs

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@SuvarnaMeenakshi SuvarnaMeenakshi mentioned this pull request Sep 25, 2023
Merged
11 tasks
@SuvarnaMeenakshi
Add github issue in condition
3cc20de 
Signed-off-by: Suvarna Meenakshi <[email protected]>
qiluo-msft
qiluo-msft previously approved these changes Sep 27, 2023
View reviewed changes
@SuvarnaMeenakshi
Fix typo in condition
abfba22 
Signed-off-by: Suvarna Meenakshi <[email protected]>
@SuvarnaMeenakshi SuvarnaMeenakshi merged commit a72a4db into sonic-net:master Sep 28, 2023
13 checks passed
@SuvarnaMeenakshi SuvarnaMeenakshi deleted the skip_v6snmp branch September 28, 2023 21:49
@SuvarnaMeenakshi
Copy link
Contributor Author

@wangxin can you include this in 202305 and 202205 branches.
We have a sonic-buildimage PR that requires this change in 202205 and 202305 for PR checker to pass.

@mssonicbld
Copy link
Collaborator

@SuvarnaMeenakshi PR conflicts with 202305 branch

@mssonicbld
Copy link
Collaborator

@SuvarnaMeenakshi PR conflicts with 202205 branch

SuvarnaMeenakshi added a commit to SuvarnaMeenakshi/sonic-mgmt that referenced this pull request Oct 6, 2023
@SuvarnaMeenakshi
[202305]Skip SNMP IPv6 testcases in 2022xx 2023xx branches (sonic-net…
70813dc 
…#10097)

What is the motivation for this PR?
Skip SNMP IPv6 related test cases in 202211,202205 and 202305 branches until the approach to fix IPv6 issue is fixed.
PR contains details of the issue and approach sonic-net/SONiC#1457

How did you do it?
Skip single asic IPv6 SNMP loopback test case and link local test case in branches with the testcase added.

How did you verify/test it?
Tested on 202205 single asic VS image

(cherry picked from commit a72a4db)
@SuvarnaMeenakshi SuvarnaMeenakshi mentioned this pull request Oct 6, 2023
Merged
6 tasks
SuvarnaMeenakshi added a commit to SuvarnaMeenakshi/sonic-mgmt that referenced this pull request Oct 6, 2023
@SuvarnaMeenakshi
[202205] Skip SNMP IPv6 testcases in 2022xx 2023xx branches (sonic-ne…
023ec42 
…t#10097)

What is the motivation for this PR?
Skip SNMP IPv6 related test cases in 202211,202205 and 202305 branches until the approach to fix IPv6 issue is fixed.
PR contains details of the issue and approach sonic-net/SONiC#1457

How did you do it?
Skip single asic IPv6 SNMP loopback test case and link local test case in branches with the testcase added.

How did you verify/test it?
Tested on 202205 single asic VS image

(cherry picked from commit a72a4db)
qiluo-msft pushed a commit that referenced this pull request Oct 6, 2023
@SuvarnaMeenakshi
[202305]Skip SNMP IPv6 testcases in 2022xx 2023xx branches (#10097) (#…
827bc69 
…10238)

What is the motivation for this PR?
cherry pick of #10097
Skip SNMP IPv6 related test cases in 202211,202205 and 202305 branches until the approach to fix IPv6 issue is fixed. PR contains details of the issue and approach sonic-net/SONiC#1457

How did you do it?
Skip single asic IPv6 SNMP loopback test case and link local test case in branches with the testcase added.

How did you verify/test it?
Tested on 202205 single asic VS image

(cherry picked from commit a72a4db)
wangxin pushed a commit that referenced this pull request Oct 10, 2023
@SuvarnaMeenakshi
[202205] Skip SNMP IPv6 testcases in 2022xx 2023xx branches (#10097) (#…
04f6a86 
…10244)

(cherry picked from commit a72a4db)

What is the motivation for this PR?
Skip SNMP IPv6 related test cases in 202211,202205 and 202305 branches until the approach to fix IPv6 issue is fixed.
PR contains details of the issue and approach sonic-net/SONiC#1457

How did you do it?
Skip single asic IPv6 SNMP loopback test case and link local test case in branches with the testcase added.

How did you verify/test it?
Tested on 202205 single asic VS image

(cherry picked from commit a72a4db)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@dgsudharsan dgsudharsan Awaiting requested review from dgsudharsan

@yutongzhang-microsoft yutongzhang-microsoft Awaiting requested review from yutongzhang-microsoft

Assignees
No one assigned
Labels
Approved for 202205 branch Approved for 202305 branch Cherry Pick Conflict_202205 Cherry Pick Conflict_202305 Included in 202205 branch Included in 202305 branch Request for 202205 branch Request for 202305 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SuvarnaMeenakshi @mssonicbld @qiluo-msft @wangxin @yxieca