Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for wait_bgp_sessions for T2 duts #16438

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Increase timeout for wait_bgp_sessions for T2 duts #16438

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d71f44b
[common/fixtures/duthost_utils.py] Increase timeout for wait_bgp_sess…
Javier-Tan Jan 10, 2025
f12b953
[common/fixtures/duthost_utils.py] Change wait_bgp_sessions increase …
Javier-Tan Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/common/fixtures/duthost_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,6 +624,10 @@ def wait_bgp_sessions(duthost, timeout=120):
A helper function to wait bgp sessions on DUT
"""
bgp_neighbors = duthost.get_bgp_neighbors_per_asic(state="all")
if duthost.is_supervisor_node():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on voq chassis supervisor has no bgp sessions, can we modify the caller to send the needed timeout when wait_bgp_sessions is called for Linecards

timeout = 900
logging.info("Wait until all bgp sessions are up in {} sec"
.format(timeout))
pytest_assert(
wait_until(timeout, 10, 0, duthost.check_bgp_session_state_all_asics, bgp_neighbors),
"Not all bgp sessions are established after config reload",
Expand Down
Loading