Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip kubesonic test case for public branch #16684

Conversation

lixiaoyuner
Copy link
Contributor

@lixiaoyuner lixiaoyuner commented Jan 26, 2025

Description of PR

Summary: The k8s feature in not enabled for public branches. So the test case should be skipped for public branches
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

The k8s feature in not enabled for public branches. So the test case should be skipped for public branches

How did you do it?

Check the image type and skip the test case if it is public branch

How did you verify/test it?

Yes

Any platform specific information?

No

Supported testbed topology if it's a new test case?

Not new case

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 7e546c3 into sonic-net:master Feb 5, 2025
12 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Feb 5, 2025
What is the motivation for this PR?
The k8s feature in not enabled for public branches. So the test case should be skipped for public branches

How did you do it?
Check the image type and skip the test case if it is public branch

How did you verify/test it?
Yes

Any platform specific information?
No

Supported testbed topology if it's a new test case?
Not new case
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #16798

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Feb 5, 2025
What is the motivation for this PR?
The k8s feature in not enabled for public branches. So the test case should be skipped for public branches

How did you do it?
Check the image type and skip the test case if it is public branch

How did you verify/test it?
Yes

Any platform specific information?
No

Supported testbed topology if it's a new test case?
Not new case
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #16799

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Feb 5, 2025
What is the motivation for this PR?
The k8s feature in not enabled for public branches. So the test case should be skipped for public branches

How did you do it?
Check the image type and skip the test case if it is public branch

How did you verify/test it?
Yes

Any platform specific information?
No

Supported testbed topology if it's a new test case?
Not new case
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #16800

mssonicbld pushed a commit that referenced this pull request Feb 7, 2025
What is the motivation for this PR?
The k8s feature in not enabled for public branches. So the test case should be skipped for public branches

How did you do it?
Check the image type and skip the test case if it is public branch

How did you verify/test it?
Yes

Any platform specific information?
No

Supported testbed topology if it's a new test case?
Not new case
mssonicbld pushed a commit that referenced this pull request Feb 8, 2025
What is the motivation for this PR?
The k8s feature in not enabled for public branches. So the test case should be skipped for public branches

How did you do it?
Check the image type and skip the test case if it is public branch

How did you verify/test it?
Yes

Any platform specific information?
No

Supported testbed topology if it's a new test case?
Not new case
mssonicbld pushed a commit that referenced this pull request Feb 10, 2025
What is the motivation for this PR?
The k8s feature in not enabled for public branches. So the test case should be skipped for public branches

How did you do it?
Check the image type and skip the test case if it is public branch

How did you verify/test it?
Yes

Any platform specific information?
No

Supported testbed topology if it's a new test case?
Not new case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants