[P4_Symbolic] Fix flaky SMT2 formula. Extend P4-Symbolic IR proto with parser/deparser related messages #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emory leaks about Z3 assertions.
|
/azp run |
|
No pipelines are associated with this pull request. |
|
Co-authored-by: Robert Halstead [email protected] |
divyagayathri-hcl
approved these changes
Dec 11, 2024
…into symbolic_import_branch_138
…h parser/deparser related messages
VSuryaprasad-HCL
force-pushed
the
symbolic_import_branch_139
branch
from
1d77fa3 to
dbee86e
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
…into symbolic_import_branch_139
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
kishanps
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyword Check:
~/sonic-buildimage/src/sonic-p4rt/sonic-pins$ ~/tools/keyword_checks.sh .
Keyword check Passed.
Build Result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel build $BAZEL_BUILD_OPTS ...
INFO: From Compiling dvaas/mirror_testbed_config.cc:
In file included from dvaas/mirror_testbed_config.cc:18:
dvaas/mirror_testbed_config.cc: In member function 'absl::lts_20230802::Status dvaas::MirrorTestbedConfigurator::ConfigureForForwardingTest()':
dvaas/mirror_testbed_config.cc:60:25: warning: 'absl::lts_20230802::Status pdpi::ClearTableEntries(pdpi::P4RuntimeSession*)' is deprecated: Use ClearEntities instead. [-Wdeprecated-declarations]
60 | RETURN_IF_ERROR(pdpi::ClearTableEntries(control_switch_api_.p4rt.get()));
| ^~~~~~~~~~~~~~~~~
./gutil/status.h:283:30: note: in definition of macro 'RETURN_IF_ERROR'
283 | for (absl::Status status = expr; !status.ok();)
| ^~~~
In file included from ./dvaas/switch_api.h:20,
from ./dvaas/mirror_testbed_config.h:21,
from dvaas/mirror_testbed_config.cc:15:
./p4_pdpi/p4_runtime_session.h:390:14: note: declared here
390 | absl::Status ClearTableEntries(P4RuntimeSession* session);
| ^~~~~~~~~~~~~~~~~
In file included from dvaas/mirror_testbed_config.cc:18:
dvaas/mirror_testbed_config.cc:60:73: warning: 'absl::lts_20230802::Status pdpi::ClearTableEntries(pdpi::P4RuntimeSession*)' is deprecated: Use ClearEntities instead. [-Wdeprecated-declarations]
60 | RETURN_IF_ERROR(pdpi::ClearTableEntries(control_switch_api_.p4rt.get()));
| ^
./gutil/status.h:283:30: note: in definition of macro 'RETURN_IF_ERROR'
283 | for (absl::Status status = expr; !status.ok();)
| ^~~~
In file included from ./dvaas/switch_api.h:20,
from ./dvaas/mirror_testbed_config.h:21,
from dvaas/mirror_testbed_config.cc:15:
./p4_pdpi/p4_runtime_session.h:390:14: note: declared here
390 | absl::Status ClearTableEntries(P4RuntimeSession* session);
| ^~~~~~~~~~~~~~~~~
INFO: From Compiling P4 program p4_fuzzer/p4_programs/acl_table_test.p4:
INFO: From Compiling p4_symbolic/tests/sai_p4_component_test.cc:
In file included from p4_symbolic/tests/sai_p4_component_test.cc:22:
p4_symbolic/tests/sai_p4_component_test.cc: In member function 'virtual void p4_symbolic::{anonymous}::P4SymbolicComponentTest_CanGenerateTestPacketsForSimpleSaiP4Entries_Test::TestBody()':
p4_symbolic/tests/sai_p4_component_test.cc:128:32: warning: 'absl::lts_20230802::StatusOrp4::v1::TableEntry pdpi::PartialPdTableEntryToPiTableEntry(const pdpi::IrP4Info&, const google::protobuf::Message&, const pdpi::TranslationOptions&)' is deprecated: Use PdTableEntryToPiEntity instead [-Wdeprecated-declarations]
128 | pdpi::PartialPdTableEntryToPiTableEntry(ir_p4info, pd_entry));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./gutil/status_matchers.h:64:43: note: in definition of macro 'ASSERT_OK_AND_ASSIGN'
64 | auto __ASSIGN_OR_RETURN_VAL(LINE) = expression;
| ^~~~~~~~~~
In file included from p4_symbolic/tests/sai_p4_component_test.cc:27:
./p4_pdpi/pd.h:141:36: note: declared here
141 | absl::StatusOrp4::v1::TableEntry PartialPdTableEntryToPiTableEntry(
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from p4_symbolic/tests/sai_p4_component_test.cc:22:
p4_symbolic/tests/sai_p4_component_test.cc:128:85: warning: 'absl::lts_20230802::StatusOrp4::v1::TableEntry pdpi::PartialPdTableEntryToPiTableEntry(const pdpi::IrP4Info&, const google::protobuf::Message&, const pdpi::TranslationOptions&)' is deprecated: Use PdTableEntryToPiEntity instead [-Wdeprecated-declarations]
128 | pdpi::PartialPdTableEntryToPiTableEntry(ir_p4info, pd_entry));
| ^
./gutil/status_matchers.h:64:43: note: in definition of macro 'ASSERT_OK_AND_ASSIGN'
64 | auto __ASSIGN_OR_RETURN_VAL(LINE) = expression;
| ^~~~~~~~~~
In file included from p4_symbolic/tests/sai_p4_component_test.cc:27:
./p4_pdpi/pd.h:141:36: note: declared here
141 | absl::StatusOrp4::v1::TableEntry PartialPdTableEntryToPiTableEntry(
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
INFO: Elapsed time: 2804.534s, Critical Path: 615.89s
INFO: 9842 processes: 3067 internal, 6775 linux-sandbox.
INFO: Build completed successfully, 9842 total actions
Test Result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS --cache_test_results=no ...
DEBUG: Rule 'com_github_nelhage_rules_boost' indicated that a canonical reproducible form can be obtained by modifying arguments shallow_since = "1619053724 -0700"
DEBUG: Repository com_github_nelhage_rules_boost instantiated at:
/sonic/src/sonic-p4rt/sonic-pins/WORKSPACE.bazel:128:9: in
/var/vsurya/.cache/bazel/_bazel_vsurya/5fd88bad78ef03829a4685c83637a020/external/com_github_p4lang_p4c/bazel/p4c_deps.bzl:25:23: in p4c_deps
Repository rule git_repository defined at:
/var/vsurya/.cache/bazel/_bazel_vsurya/5fd88bad78ef03829a4685c83637a020/external/bazel_tools/tools/build_defs/repo/git.bzl:199:33: in
DEBUG: Rule 'com_github_bazelbuild_buildtools' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "e3bb0dc8b0274ea1aca75f1f8c0c835adbe589708ea89bf698069d0790701ea3"
DEBUG: Repository com_github_bazelbuild_buildtools instantiated at:
/sonic/src/sonic-p4rt/sonic-pins/WORKSPACE.bazel:42:16: in
/sonic/src/sonic-p4rt/sonic-pins/pins_infra_deps.bzl:17:21: in pins_infra_deps
Repository rule http_archive defined at:
/var/vsurya/.cache/bazel/_bazel_vsurya/5fd88bad78ef03829a4685c83637a020/external/bazel_tools/tools/build_defs/repo/http.bzl:355:31: in
DEBUG: Rule 'sonic_swss_common' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "179a18c55c696c2ea9ed3f015e7e24133f61416a33cad1a2650eaa300510f339"
DEBUG: Repository sonic_swss_common instantiated at:
/sonic/src/sonic-p4rt/sonic-pins/WORKSPACE.bazel:42:16: in
/sonic/src/sonic-p4rt/sonic-pins/pins_infra_deps.bzl:228:21: in pins_infra_deps
Repository rule http_archive defined at:
/var/vsurya/.cache/bazel/_bazel_vsurya/5fd88bad78ef03829a4685c83637a020/external/bazel_tools/tools/build_defs/repo/http.bzl:355:31: in
INFO: Analyzed 630 targets (1 packages loaded, 645 targets configured).
INFO: Found 421 targets and 209 test targets...
INFO: Elapsed time: 206.190s, Critical Path: 120.23s
INFO: 263 processes: 318 linux-sandbox, 18 local.
INFO: Build completed successfully, 263 total actions
//dvaas:port_id_map_test PASSED in 0.9s
//dvaas:test_run_validation_golden_test PASSED in 0.4s
//dvaas:test_run_validation_test PASSED in 0.7s
//dvaas:test_run_validation_test_runner PASSED in 0.1s
//dvaas:test_vector_stats_diff_test PASSED in 0.4s
//dvaas:test_vector_stats_test PASSED in 0.0s
//dvaas:test_vector_test PASSED in 1.5s
//p4rt_app/tests:packetio_test PASSED in 5.1s
//p4rt_app/tests:port_name_and_id_test PASSED in 4.5s
//p4rt_app/tests:resource_limits_test PASSED in 2.6s
//p4rt_app/tests:response_path_test PASSED in 6.1s
//p4rt_app/tests:role_test PASSED in 1.6s
//p4rt_app/tests:state_verification_test PASSED in 3.2s
//p4rt_app/tests:vrf_table_test PASSED in 2.8s
//p4rt_app/tests/lib:app_db_entry_builder_test PASSED in 0.1s
//p4rt_app/utils:event_data_tracker_test PASSED in 0.1s
//p4rt_app/utils:table_utility_test PASSED in 1.0s
//sai_p4/instantiations/google:clos_stage_test PASSED in 0.5s
//sai_p4/instantiations/google:fabric_border_router_p4info_up_to_date_test PASSED in 0.1s
//sai_p4/instantiations/google:middleblock_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_nonstandard_platforms_build_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_nonstandard_platforms_cc_test PASSED in 0.9s
//sai_p4/instantiations/google:sai_p4info_fetcher_test PASSED in 0.8s
//sai_p4/instantiations/google:sai_p4info_test PASSED in 1.3s
//sai_p4/instantiations/google:sai_pd_proto_test PASSED in 0.1s
//sai_p4/instantiations/google:sai_pd_util_test PASSED in 0.6s
//sai_p4/instantiations/google:tor_p4info_up_to_date_test PASSED in 0.1s
//sai_p4/instantiations/google:union_p4info_up_to_date_test PASSED in 0.6s
//sai_p4/instantiations/google:wbb_p4info_up_to_date_test PASSED in 0.1s
//sai_p4/instantiations/google/test_tools:table_entry_generator_helper_test PASSED in 1.4s
//sai_p4/instantiations/google/test_tools:test_entries_test PASSED in 1.1s
//sai_p4/instantiations/google/tests:p4_fuzzer_integration_test PASSED in 9.3s
//sai_p4/tools:p4info_tools_test PASSED in 0.9s
//sai_p4/tools:packetio_tools_test PASSED in 0.9s
//tests:thinkit_gnmi_interface_util_tests PASSED in 1.3s
//tests/lib:p4rt_fixed_table_programming_helper_test PASSED in 1.0s
//tests/lib:switch_test_setup_helpers_golden_test PASSED in 2.4s
//tests/lib:switch_test_setup_helpers_golden_test_runner PASSED in 0.1s
//tests/qos:gnmi_parsers_test PASSED in 0.3s
//tests/qos:gnmi_parsers_test_runner PASSED in 0.0s
//thinkit:bazel_test_environment_test PASSED in 0.6s
//thinkit:generic_testbed_test PASSED in 6.6s
//thinkit:mock_control_device_test PASSED in 0.6s
//thinkit:mock_generic_testbed_test PASSED in 10.7s
//thinkit:mock_mirror_testbed_test PASSED in 0.9s
//thinkit:mock_ssh_client_test PASSED in 0.3s
//thinkit:mock_switch_test PASSED in 1.2s
//thinkit:mock_test_environment_test PASSED in 0.2s
//thinkit:switch_test PASSED in 1.0s
//sai_p4/instantiations/google/tests:p4_constraints_integration_test PASSED in 1.1s
Stats over 5 runs: max = 1.1s, min = 0.8s, avg = 0.9s, dev = 0.1s
//sai_p4/instantiations/google/test_tools:table_entry_generator_test PASSED in 43.8s
Stats over 50 runs: max = 43.8s, min = 0.8s, avg = 2.7s, dev = 6.3s
Executed 209 out of 209 tests: 209 tests pass.
INFO: Build completed successfully, 263 total actions