[P4_Symbolic] Extend IR to include field order in header types.

[VSuryaprasad-HCL]

Keyword Check:
~/sonic-buildimage/src/sonic-p4rt/sonic-pins$ ~/tools/keyword_checks.sh .
Keyword check Passed.

Build Result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel build $BAZEL_BUILD_OPTS ...
INFO: Analyzed 630 targets (0 packages loaded, 0 targets configured).
INFO: Found 630 targets...
INFO: From Compiling p4_symbolic/symbolic/table.cc [for host]:
p4_symbolic/symbolic/table.cc: In function 'std::vector<std::pair<int, pdpi::IrTableEntry> > p4_symbolic::symbolic::table::{anonymous}::SortEntries(const p4_symbolic::ir::Table&, const std::vectorpdpi::IrTableEntry&)':
p4_symbolic/symbolic/table.cc:115:21: warning: comparison of integer expressions of different signedness: 'int' and 'std::vectorpdpi::IrTableEntry::size_type' {aka 'long unsigned int'} [-Wsign-compare]
115 | for (int i = 0; i < entries.size(); i++) {
| ~~^~~~~~~~~~~~~~~~
INFO: From Compiling p4_symbolic/sai/parser.cc [for host]:
p4_symbolic/sai/parser.cc: In function 'absl::lts_20230802::StatusOr<std::vectorz3::expr > p4_symbolic::EvaluateSaiParser(const SymbolicPerPacketState&)':
p4_symbolic/sai/parser.cc:93:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
93 | constraints.push_back(icmp.valid == (ipv4.valid && ipv4.protocol == 0x01 ||
| ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
p4_symbolic/sai/parser.cc:95:50: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
95 | constraints.push_back(tcp.valid == (ipv4.valid && ipv4.protocol == 0x06 ||
| ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
p4_symbolic/sai/parser.cc:97:50: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
97 | constraints.push_back(udp.valid == (ipv4.valid && ipv4.protocol == 0x11 ||
| ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
INFO: From Compiling p4_symbolic/main.cc [for host]:
In file included from ./gutil/io.h:22,
from p4_symbolic/main.cc:30:
p4_symbolic/main.cc: In function 'absl::lts_20230802::Status {anonymous}::ParseAndEvaluate()':
p4_symbolic/main.cc:114:75: warning: 'absl::lts_20230802::StatusOr<std::optional<p4_symbolic::symbolic::ConcreteContext> > p4_symbolic::symbolic::Solve(const std::unique_ptr<p4_symbolic::symbolic::SolverState>&, const Assertion&)' is deprecated: Use the overload Solve(SolverState&, const Assertion&) instead. [-Wdeprecated-declarations]
114 | p4_symbolic::symbolic::Solve(solver_state, table_entry_assertion));
| ^
./gutil/status.h:294:43: note: in definition of macro '__ASSIGN_OR_RETURN'
294 | auto __ASSIGN_OR_RETURN_VAL(LINE) = expr;
| ^~~~
p4_symbolic/main.cc:112:7: note: in expansion of macro 'ASSIGN_OR_RETURN'
112 | ASSIGN_OR_RETURN(
| ^~~~~~~~~~~~~~~~
In file included from ./p4_symbolic/parser.h:28,
from p4_symbolic/main.cc:33:
./p4_symbolic/symbolic/symbolic.h:281:48: note: declared here
281 | absl::StatusOr<std::optional> Solve(
| ^~~~~
INFO: From Compiling p4_symbolic/symbolic/util.cc [for host]:
p4_symbolic/symbolic/util.cc:36:6: warning: 'bool p4_symbolic::symbolic::util::{anonymous}::Z3BooltoBool(Z3_lbool)' defined but not used [-Wunused-function]
36 | bool Z3BooltoBool(Z3_lbool z3_bool) {
| ^~~~~~~~~~~~
INFO: From Compiling p4_symbolic/ir/cfg.cc [for host]:
INFO: From Compiling p4_symbolic/ir/cfg.cc:
In file included from p4_symbolic/ir/cfg.cc:15:
./p4_symbolic/ir/cfg.h:79:3: warning: multi-line comment [-Wcomment]
79 | // /
| ^
p4_symbolic/ir/cfg.cc:349:5: warning: multi-line comment [-Wcomment]
349 | // /
| ^
p4_symbolic/ir/cfg.cc:388:7: warning: multi-line comment [-Wcomment]
388 | // /
| ^
p4_symbolic/ir/cfg.cc: In function 'p4_symbolic::ir::ControlPath p4_symbolic::ir::{anonymous}::LongestCommonPrefix(const ControlPath&, const ControlPath&)':
p4_symbolic/ir/cfg.cc:101:16: warning: comparison of integer expressions of different signedness: 'int' and 'std::vector<std::__cxx11::basic_string >::size_type' {aka 'long unsigned int'} [-Wsign-compare]
101 | while (index < l.size() && index < r.size() && l[index] == r[index]) {
| ~~~~~~^~~~~~~~~~
p4_symbolic/ir/cfg.cc:101:36: warning: comparison of integer expressions of different signedness: 'int' and 'std::vector<std::__cxx11::basic_string >::size_type' {aka 'long unsigned int'} [-Wsign-compare]
101 | while (index < l.size() && index < r.size() && l[index] == r[index]) {
| ~~~~~~^~~~~~~~~~
INFO: From Compiling p4_symbolic/ir/ir.cc:
In file included from p4_symbolic/ir/ir.cc:39:
./p4_symbolic/ir/cfg.h:79:3: warning: multi-line comment [-Wcomment]
79 | // /
| ^
INFO: Elapsed time: 56.423s, Critical Path: 20.06s
INFO: 78 processes: 3 internal, 75 linux-sandbox.
INFO: Build completed successfully, 78 total actions

Test Result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS --cache_test_results=no ...
INFO: Analyzed 630 targets (0 packages loaded, 0 targets configured).
INFO: Found 421 targets and 209 test targets...
INFO: Elapsed time: 190.242s, Critical Path: 121.47s
INFO: 263 processes: 318 linux-sandbox, 18 local.
INFO: Build completed successfully, 263 total actions
//dvaas:port_id_map_test PASSED in 0.8s
//dvaas:test_run_validation_golden_test PASSED in 0.1s
//dvaas:test_run_validation_test PASSED in 0.7s
//dvaas:test_run_validation_test_runner PASSED in 0.1s
//dvaas:test_vector_stats_diff_test PASSED in 0.0s
//dvaas:test_vector_stats_test PASSED in 0.1s
//dvaas:test_vector_test PASSED in 0.6s
//dvaas:user_provided_packet_test_vector_diff_test PASSED in 0.1s
//dvaas:user_provided_packet_test_vector_test PASSED in 0.1s
//gutil:collections_test PASSED in 0.5s
//p4rt_app/tests:packetio_test PASSED in 4.9s
//p4rt_app/tests:port_name_and_id_test PASSED in 5.1s
//p4rt_app/tests:resource_limits_test PASSED in 3.5s
//p4rt_app/tests:response_path_test PASSED in 6.4s
//p4rt_app/tests:role_test PASSED in 1.5s
//p4rt_app/tests:state_verification_test PASSED in 3.4s
//p4rt_app/tests:vrf_table_test PASSED in 2.6s
//p4rt_app/tests/lib:app_db_entry_builder_test PASSED in 0.0s
//p4rt_app/utils:event_data_tracker_test PASSED in 0.0s
//p4rt_app/utils:table_utility_test PASSED in 0.7s
//sai_p4/instantiations/google:clos_stage_test PASSED in 0.5s
//sai_p4/instantiations/google:fabric_border_router_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google:middleblock_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_nonstandard_platforms_build_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_nonstandard_platforms_cc_test PASSED in 0.6s
//sai_p4/instantiations/google:sai_p4info_fetcher_test PASSED in 0.7s
//sai_p4/instantiations/google:sai_p4info_test PASSED in 1.2s
//sai_p4/instantiations/google:sai_pd_proto_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_pd_util_test PASSED in 0.6s
//sai_p4/instantiations/google:tor_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google:union_p4info_up_to_date_test PASSED in 0.1s
//sai_p4/instantiations/google:wbb_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google/test_tools:table_entry_generator_helper_test PASSED in 3.1s
//sai_p4/instantiations/google/test_tools:test_entries_test PASSED in 1.0s
//sai_p4/instantiations/google/tests:p4_fuzzer_integration_test PASSED in 3.6s
//sai_p4/tools:p4info_tools_test PASSED in 0.6s
//sai_p4/tools:packetio_tools_test PASSED in 0.8s
//tests:thinkit_gnmi_interface_util_tests PASSED in 1.1s
//tests/lib:p4rt_fixed_table_programming_helper_test PASSED in 0.8s
//tests/lib:switch_test_setup_helpers_golden_test PASSED in 0.1s
//tests/lib:switch_test_setup_helpers_golden_test_runner PASSED in 0.1s
//tests/qos:gnmi_parsers_test PASSED in 0.1s
//tests/qos:gnmi_parsers_test_runner PASSED in 0.1s
//thinkit:bazel_test_environment_test PASSED in 0.5s
//thinkit:generic_testbed_test PASSED in 0.9s
//thinkit:mock_control_device_test PASSED in 0.5s
//thinkit:mock_generic_testbed_test PASSED in 0.7s
//thinkit:mock_mirror_testbed_test PASSED in 0.7s
//thinkit:mock_ssh_client_test PASSED in 0.0s
//thinkit:mock_switch_test PASSED in 0.7s
//thinkit:mock_test_environment_test PASSED in 0.1s
//thinkit:switch_test PASSED in 0.7s
//sai_p4/instantiations/google/tests:p4_constraints_integration_test PASSED in 0.9s
Stats over 5 runs: max = 0.9s, min = 0.7s, avg = 0.8s, dev = 0.1s
//sai_p4/instantiations/google/test_tools:table_entry_generator_test PASSED in 44.0s
Stats over 50 runs: max = 44.0s, min = 0.8s, avg = 2.7s, dev = 8.4s

Executed 209 out of 209 tests: 209 tests pass.
INFO: Build completed successfully, 263 total actions

[mssonicbld]

/azp run

[azure-pipelines]

No pipelines are associated with this pull request.

[VSuryaprasad-HCL]

Co-authored-by: Srikishen Pondicherry Shanmugam [email protected]

[divyagayathri-hcl]

@kishanps, Could you please review.
Thanks.

[mssonicbld]

/azp run

[azure-pipelines]

No pipelines are associated with this pull request.