Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VDM and Status related cmis fields for onboarding xcvr diagnostic features #510

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

mihirpat1
Copy link
Contributor

@mihirpat1 mihirpat1 commented Oct 31, 2024

Description

We need to add VDM and status related fields to be in line with the changes proposed via the below HLD
HLD for diagnostic monitoring of CMIS based transceivers by mihirpat1 · Pull Request #1828 · sonic-net/SONiC (github.com)

Motivation and Context

  1. Added tx_eq_fault{lane_num} field to get_transceiver_status API
  2. Added dpdeinit_hostlane field to get_transceiver_status API
  3. Added laser_temperature_media{lane_num} in VDM descriptor
  4. Fixed a baseline failure seen while executing test_cmis.py::TestCmis::test_get_transceiver_status individually.
    • The test was passing when all the tests of test_cmis.py are executed and failed only when executed individually. This is likely due to the field being already initialized by a different test which executed before test_get_transceiver_status is executed.
    • Failure details
			                    trans_status['txbiaslowwarning_flag%d' % lane] = tx_bias_flag_dict['tx_bias_low_warn']['TxBiasLowWarnFlag%d' % lane]
			>           self.vdm_dict = self.get_vdm(self.vdm.VDM_FLAG)
			E           AttributeError: 'NoneType' object has no attribute 'VDM_FLAG'

			../../sonic_platform_base/sonic_xcvr/api/public/cmis.py:2083: AttributeError

How Has This Been Tested?

  1. Added tx_eq_fault{lane_num} field to get_transceiver_status API
root@sonic:/home/admin# redis-cli -n 6 hgetall "TRANSCEIVER_STATUS|Ethernet0"
....
183) "tx_eq_fault1"
184) "N/A"
185) "tx_eq_fault2"
186) "N/A"
187) "tx_eq_fault3"
188) "N/A"
189) "tx_eq_fault4"
190) "N/A"
191) "tx_eq_fault5"
192) "N/A"
193) "tx_eq_fault6"
194) "N/A"
195) "tx_eq_fault7"
196) "N/A"
197) "tx_eq_fault8"
198) "N/A"
  1. Added dpdeinit_hostlane field to get_transceiver_status API
root@sonic:/home/admin# redis-cli -n 6 hgetall "TRANSCEIVER_STATUS|Ethernet0"
....
215) "dpdeinit_hostlane1"
216) "False"
217) "dpdeinit_hostlane2"
218) "False"
219) "dpdeinit_hostlane3"
220) "False"
221) "dpdeinit_hostlane4"
222) "False"
223) "dpdeinit_hostlane5"
224) "False"
225) "dpdeinit_hostlane6"
226) "False"
227) "dpdeinit_hostlane7"
228) "False"
229) "dpdeinit_hostlane8"
230) "False"
  1. Added laser_temperature_media{lane_num} in VDM descriptor
root@sonic:/home/admin# redis-cli -n 6 hgetall "TRANSCEIVER_DOM_SENSOR|Ethernet0"
...
 55) "laser_temperature_media1"
 56) "61.0"
 57) "laser_temperature_media2"
 58) "61.0"
 59) "laser_temperature_media3"
 60) "61.0"
 61) "laser_temperature_media4"
 62) "61.0"

Additional Information (Optional)

MSFT ADO - 29932092

@mihirpat1 mihirpat1 changed the title Add/modify VDM and Status related cmis fields for onboarding xcvr diagnostic features Add VDM and Status related cmis fields for onboarding xcvr diagnostic features Nov 1, 2024
@mihirpat1 mihirpat1 marked this pull request as ready for review November 1, 2024 00:15
@mihirpat1 mihirpat1 requested a review from prgeor November 1, 2024 00:27
@prgeor prgeor merged commit 59babf5 into sonic-net:master Nov 1, 2024
5 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-platform-common that referenced this pull request Nov 1, 2024
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants