PMON Voltage and Current Sensor Monitor #393
Conversation
| self._refresh_voltage_status(CHASSIS_INFO_KEY, voltage_sensor, index) | ||
|
|
||
| if self.is_chassis_system: | ||
| available_voltage_sensors = set() |
There was a problem hiding this comment.
Why only handle this for chassis system? For NON chassis system, PSU also can be hot swapable.
There was a problem hiding this comment.
PSU sensors are currently handled by PSUd. So I was not expecting PSU sensors to be monitored here. Primarily we wanted to handle voltage/current sensors in CPU-less modules such as Fabric cards.
|
@Junchao-Mellanox , Pls check this and other PRs related to this with the updates. |
|
@Junchao-Mellanox can you please review again @bmridul please rebase it as it is out of date |
|
@gechiang we would need in msft repo. Since this is enhancement we would need be able to take in 202205 branch. |
|
@abdosi, same issues where there is no msft repo for this submodule and there is no plan for build team to support this new msft repo. So unless it is a bug fix, it will likely not be able to be taken in for the 202205 at all... |
|
Hi @abdosi , the HLD is not approved, it is in a "Requested Change" status. Should we hold on the merge/cherry-pick until major comments are addressed? |
|
new feature, no cherry pick |
Implementation of SensorMonitor daemon which would provide monitoring of voltage and current sensors.
Description
Sensormond daemon is introduced. It collects the voltage and current sensor information from the platform and populates in the StateDB. The sensor data is available to view using CLIs. Sensormond raises syslogs when the sensors report measurement outside the thresholds.
Motivation and Context
The change is required for the implementation for the sensor monitoring daemon described in the HLD for voltage and current sensors monitoring.
sonic-net/SONiC#1394
How Has This Been Tested?
This is tested with unit test (included in PR) and on target with CLIs and instrumentation of faults.