Add Port SI Configuration Per Speed #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dent Module feature
…ication_desired()
tshalvi
changed the title
…ing xcvrd accordingly
…function check_port_in_range() from media_settings_parser back to xcvrd as optics_si_parser also uses it
tshalvi
changed the title
prgeor
reviewed
Oct 19, 2023
Junchao-Mellanox
approved these changes
Nov 27, 2023
prgeor
approved these changes
Dec 1, 2023
|
@yxieca - Can you please help in merging this to 202311? |
|
@tshalvi @liat-grozovik please see cherry pick conflict so may need separate pr for 202311 |
|
@mihirpat1 , This PR is already in 202311 branch. |
liushilongbuaa
added
Included in 202311 Branch
and removed
Cherry Pick Conflict_202311
labels
|
@yxieca @liushilongbuaa would you please remove the tag "request for 202311 branch" as it is already included in 202311? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have updated the lookup in media_settings.json. With the updated parser, media_settings.json now supports different SI values for various lane speeds. Previously, get_media_settings_key() returned two types of keys: vendor_key and media_key. With these code changes, three keys are now returned: vendor_key, media_key, and lane_speed_key. The parser, implemented in get_media_settings_value(), intelligently utilizes the lane_speed_key only for JSON files that support per-speed port SI values. In cases where the JSON does not support this feature, the parser's functionality remains unchanged.
Motivation and Context
To achieve optimal configuration of their SerDes, some vendors wish to have the option to configure SerDes SI based on lane speeds. Therefore, we want to enhance the current ASIC configuration to provide support for configurations that take into account lane speed.
How Has This Been Tested?
I was running the existing unit tests to test these changes, and updated them if needed. They all passed.
Soon I will add new unit test to cover all my changes.