[PMON][psud] Fix the repeated NOTICE log message on Chassis platform #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mlok <[email protected]>
assrinivasan
approved these changes
Aug 2, 2024
The context of log message is not changed. This PR is to stop logging the same message periodically when the Pusd Master Status is not changed. On the stablized system, we found that the same message is repeated thousand times (see below message). Also, the Pusd.set_status_master_led() has been trigged repeadedly to call the platform specified code to set the Master Led although the Status is not changed. |
prgeor
approved these changes
Sep 12, 2024
|
@prgeor @judyjoseph Please cherry-pick this PR to 202405 branch |
mssonicbld
pushed a commit
to mssonicbld/sonic-platform-daemons
that referenced
this pull request
Nov 18, 2024
…onic-net#529) * [PMON][psud] Fix the repeated NOTICE log message on Chassis platform Signed-off-by: mlok <[email protected]> * Fix the Unit test --------- Signed-off-by: mlok <[email protected]>
|
Cherry-pick PR to 202405: #561 |
mssonicbld
pushed a commit
that referenced
this pull request
Nov 19, 2024
…529) * [PMON][psud] Fix the repeated NOTICE log message on Chassis platform Signed-off-by: mlok <[email protected]> * Fix the Unit test --------- Signed-off-by: mlok <[email protected]>
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In psud script, first_run is always true in PsuChassisInfo class. This causes the method update_master_status() always set the psu status_master_led and log the status change messages although the status is not changed. The same NOTICE message is repeated and never stop. Address this issue, added code to set the first_run to False after the first run. This initializes set_led to False before the calculation. So that it won't be True to trigger the set_status_maste_led() and log the same message while the status has NO change.
Motivation and Context
This PR fixes sonic-net/sonic-buildimage#19780 and not set the LED to the same state or log the same message when there is NO change.
How Has This Been Tested?
Checking the syslog on the SUP. The following message will not be repeated if the status is not changed
Additional Information (Optional)