-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SmartSwitch] Enhance PCIe device check to skip the warning log, if device is in detaching mode #546
Open
vvolam
wants to merge
10
commits into
sonic-net:master
Choose a base branch
from
vvolam:ss-reboot
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+110
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvolam
changed the title
Enhance PCIe device check to skip the warning log, if device is in detaching mode
[SmartSwitch] Enhance PCIe device check to skip the warning log, if device is in detaching mode
Nov 11, 2024
prgeor
reviewed
Nov 17, 2024
prgeor
reviewed
Nov 17, 2024
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
reviewed
Nov 21, 2024
prgeor
reviewed
Nov 21, 2024
@prgeor please help review and merge, if no other changes needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new function "is_device_in_detaching_mode" to query state_db for devices in detaching mode. Enhance "check_pcie_devices" to invoke this function to skip the warning log, if device is in detaching mode.
Motivation and Context
Changes are being done based on the reboot HLD
How Has This Been Tested?
Pending
Additional Information (Optional)