reset active application code as 'N/A' when port shutdown #550

chiourung · 2024-10-22T09:20:13Z

Description

Motivation and Context

In the add_rack test, it would compare the TRANSCEIVER_INFO for two cases:
case 1. config reload (the admin status of Ethernet64 is down in config_db.json)
case 2. config reload (the admin status of Ethernet64 is up in config_db.json) and then shutdown Ethernet64

In case 1. it would not do CMIS init and the active application is 'N/A'.
In case 2. it would do CMIS init first and then disable TX. The active application would retain the value of the last CMIS init.
=> Modify the code to reset the active application on port shutdown to ensure that the active application would be the same for the above two cases.

How Has This Been Tested?

root@ais800-64o-1:/# show interfaces status Ethernet0
  Interface        Lanes    Speed    MTU    FEC          Alias    Vlan    Oper    Admin                           Type    Asym PFC
-----------  -----------  -------  -----  -----  -------------  ------  ------  -------  -----------------------------  ----------
  Ethernet0  25,26,27,28     400G   9100    N/A  Eth1/1(Port1)  routed      up       up  OSFP 8X Pluggable Transceiver         off
root@ais800-64o-1:/# show interfaces transceiver eeprom Ethernet0
Ethernet0: SFP EEPROM detected
        Active Firmware: N/A
        Active application selected code assigned to host lane 1: 2
        Active application selected code assigned to host lane 2: 2
        Active application selected code assigned to host lane 3: 2
        Active application selected code assigned to host lane 4: 2
        Active application selected code assigned to host lane 5: N/A
        Active application selected code assigned to host lane 6: N/A
        Active application selected code assigned to host lane 7: N/A
        Active application selected code assigned to host lane 8: N/A
        Application Advertisement: 800G L C2M (placeholder) - Host Assign (0x1) - 800GBASE-DR8-2 (placeholder) - Media Assign (0x1)
                                   400GAUI-4-L C2M (Annex 120G) - Host Assign (0x11) - 400G-FR4/400GBASE-FR4 (Cl 151) - Media Assign (0x11)
                                   200GAUI-2-L C2M (Annex 120G) - Host Assign (0x55) - Undefined - Media Assign (0x55)
                                   100GAUI-1-L C2M (Annex 120G) - Host Assign (0xff) - 100G-FR/100GBASE-FR1 (Cl 140) - Media Assign (0xff)
                                   200GAUI-4 C2M (Annex 120E) - Host Assign (0x11) - 200GBASE-FR4 (Cl 122) - Media Assign (0x11)
        CMIS Rev: 5.0
        Connector: LC
        Encoding: N/A
        Extended Identifier: Power Class 7 (14.0W Max)
        Extended RateSelect Compliance: N/A
        Host Lane Count: 4
        Identifier: OSFP 8X Pluggable Transceiver
        Inactive Firmware: N/A
        Length Cable Assembly(m): 0.0
        Media Interface Technology: 1310 nm EML
        Media Lane Count: 4
        Module Hardware Rev: 1.0
        Nominal Bit Rate(100Mbs): 0
        Specification compliance: sm_media_interface
        Supported Max Laser Frequency: N/A
        Supported Max TX Power: N/A
        Supported Min Laser Frequency: N/A
        Supported Min TX Power: N/A
        Vendor Date Code(YYYY-MM-DD Lot): 2024-03-22
        Vendor Name: Edgecore
        Vendor OUI: 3c-2c-99
        Vendor PN: ET8001-2FR4
        Vendor Rev: 50
        Vendor SN: L12412000257
root@ais800-64o-1:/# config interface shutdown Ethernet0
root@ais800-64o-1:/# show interfaces transceiver eeprom Ethernet0
Ethernet0: SFP EEPROM detected
        Active Firmware: N/A
        Active application selected code assigned to host lane 1: N/A
        Active application selected code assigned to host lane 2: N/A
        Active application selected code assigned to host lane 3: N/A
        Active application selected code assigned to host lane 4: N/A
        Active application selected code assigned to host lane 5: N/A
        Active application selected code assigned to host lane 6: N/A
        Active application selected code assigned to host lane 7: N/A
        Active application selected code assigned to host lane 8: N/A
        Application Advertisement: 800G L C2M (placeholder) - Host Assign (0x1) - 800GBASE-DR8-2 (placeholder) - Media Assign (0x1)
                                   400GAUI-4-L C2M (Annex 120G) - Host Assign (0x11) - 400G-FR4/400GBASE-FR4 (Cl 151) - Media Assign (0x11)
                                   200GAUI-2-L C2M (Annex 120G) - Host Assign (0x55) - Undefined - Media Assign (0x55)
                                   100GAUI-1-L C2M (Annex 120G) - Host Assign (0xff) - 100G-FR/100GBASE-FR1 (Cl 140) - Media Assign (0xff)
                                   200GAUI-4 C2M (Annex 120E) - Host Assign (0x11) - 200GBASE-FR4 (Cl 122) - Media Assign (0x11)
        CMIS Rev: 5.0
        Connector: LC
        Encoding: N/A
        Extended Identifier: Power Class 7 (14.0W Max)
        Extended RateSelect Compliance: N/A
        Host Lane Count: N/A
        Identifier: OSFP 8X Pluggable Transceiver
        Inactive Firmware: N/A
        Length Cable Assembly(m): 0.0
        Media Interface Technology: 1310 nm EML
        Media Lane Count: N/A
        Module Hardware Rev: 1.0
        Nominal Bit Rate(100Mbs): 0
        Specification compliance: sm_media_interface
        Supported Max Laser Frequency: N/A
        Supported Max TX Power: N/A
        Supported Min Laser Frequency: N/A
        Supported Min TX Power: N/A
        Vendor Date Code(YYYY-MM-DD Lot): 2024-03-22
        Vendor Name: Edgecore
        Vendor OUI: 3c-2c-99
        Vendor PN: ET8001-2FR4
        Vendor Rev: 50
        Vendor SN: L12412000257

Additional Information (Optional)

Signed-off-by: chiourung_huang <[email protected]>

prgeor · 2024-10-22T18:46:53Z

@chiourung please share the output of show interface transceiver info when port is up and port is down

prgeor · 2024-10-22T18:47:04Z

@chiourung please fix the build error

chiourung · 2024-10-23T03:26:40Z

@chiourung please share the output of show interface transceiver info when port is up and port is down

Update in Description

chiourung · 2024-10-23T03:26:49Z

@chiourung please fix the build error

Done

prgeor

@mihirpat1 can you review?

mihirpat1 · 2024-12-02T21:56:02Z

sonic-xcvrd/xcvrd/xcvrd.py

@@ -1468,6 +1489,7 @@ def task_worker(self):
                               self.log_notice("{} Forcing Tx laser OFF".format(lport))
                               # Force DataPath re-init
                               api.tx_disable_channel(media_lanes_mask, True)
+                               self.reset_port_active_apsel_to_db(lport, host_lanes_mask)


@chiourung Can we reuse post_port_active_apsel_to_db function and introduce an additional argument to ignore reading the active application to reduce code replication?

…on code as 'N/A'

mihirpat1 · 2024-12-04T18:47:48Z

@chiourung Please help in fixing the build failure.

chiourung · 2024-12-05T01:19:44Z

/azpw run

mssonicbld · 2024-12-05T01:19:46Z

/AzurePipelines run

azure-pipelines · 2024-12-05T01:19:55Z

Azure Pipelines successfully started running 1 pipeline(s).

chiourung · 2024-12-05T02:46:28Z

@chiourung Please help in fixing the build failure.

The build failure is

+ sudo dpkg -i 'libnl-3-200_*.deb'
dpkg: error: cannot access archive 'libnl-3-200_*.deb': No such file or directory

##[error]Bash exited with code '2'.

chiourung · 2024-12-10T02:59:03Z

/azpw run

mssonicbld · 2024-12-10T02:59:06Z

/AzurePipelines run

azure-pipelines · 2024-12-10T02:59:15Z

Azure Pipelines successfully started running 1 pipeline(s).

chiourung · 2024-12-13T00:55:38Z

/azpw run

mssonicbld · 2024-12-13T00:55:41Z

/AzurePipelines run

azure-pipelines · 2024-12-13T00:55:50Z

Azure Pipelines successfully started running 1 pipeline(s).

reset active application code as 'N/A' when port shutdown

f29a5db

Signed-off-by: chiourung_huang <[email protected]>

Fix unit test error

6128836

prgeor requested a review from mihirpat1 December 1, 2024 14:43

prgeor reviewed Dec 1, 2024

View reviewed changes

mihirpat1 reviewed Dec 2, 2024

View reviewed changes

reuse post_port_active_apsel_to_db function to reset active applicati…

89000a5

…on code as 'N/A'

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

reset active application code as 'N/A' when port shutdown #550

reset active application code as 'N/A' when port shutdown #550

chiourung commented Oct 22, 2024 •

edited

Loading

prgeor commented Oct 22, 2024

prgeor commented Oct 22, 2024

chiourung commented Oct 23, 2024

chiourung commented Oct 23, 2024

prgeor left a comment

mihirpat1 Dec 2, 2024

mihirpat1 commented Dec 4, 2024

chiourung commented Dec 5, 2024

mssonicbld commented Dec 5, 2024

azure-pipelines bot commented Dec 5, 2024

chiourung commented Dec 5, 2024

chiourung commented Dec 10, 2024

mssonicbld commented Dec 10, 2024

azure-pipelines bot commented Dec 10, 2024

chiourung commented Dec 13, 2024

mssonicbld commented Dec 13, 2024

azure-pipelines bot commented Dec 13, 2024

reset active application code as 'N/A' when port shutdown #550

Are you sure you want to change the base?

reset active application code as 'N/A' when port shutdown #550

Conversation

chiourung commented Oct 22, 2024 • edited Loading

Description

Motivation and Context

How Has This Been Tested?

Additional Information (Optional)

prgeor commented Oct 22, 2024

prgeor commented Oct 22, 2024

chiourung commented Oct 23, 2024

chiourung commented Oct 23, 2024

prgeor left a comment

Choose a reason for hiding this comment

mihirpat1 Dec 2, 2024

Choose a reason for hiding this comment

mihirpat1 commented Dec 4, 2024

chiourung commented Dec 5, 2024

mssonicbld commented Dec 5, 2024

azure-pipelines bot commented Dec 5, 2024

chiourung commented Dec 5, 2024

chiourung commented Dec 10, 2024

mssonicbld commented Dec 10, 2024

azure-pipelines bot commented Dec 10, 2024

chiourung commented Dec 13, 2024

mssonicbld commented Dec 13, 2024

azure-pipelines bot commented Dec 13, 2024

chiourung commented Oct 22, 2024 •

edited

Loading