Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xcvrd] Fix swsscommon set port table handle in media_settings parser #562

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vdahiya12
Copy link
Contributor

@vdahiya12 vdahiya12 commented Nov 19, 2024

instead of ProducerStateTable for settings kvp, the xcvrd daemon should be just using swsscommon.Table which is what this PR fixes.

Description

The method notify_media_setting was updated to use get_app_set_port_tbl() instead of get_app_port_tbl() for interacting with the application port table. This change modifies the way media settings are published to the application database for a given logical port.

A new table, app_set_port_tbl, was added to the XcvrTableHelper class to support the updated functionality in media_settings_parser.py. The table is initialized in the constructor and used by the get_app_set_port_tbl() method.

The changes include:

  • Adding app_set_port_tbl to store the application set port table.
  • Implementing a getter method get_app_set_port_tbl() to retrieve the new table.

Motivation and Context

since ProducerStateTable cannot be used to set key-value pairs in redis, the xcvrd daemon should be just using swsscommon.Table for PORT_TABLE which is what this PR fixes.

How Has This Been Tested?

UT and testing on Arista 7260cx3 testbed

Additional Information (Optional)

@vdahiya12 vdahiya12 requested a review from prgeor November 19, 2024 00:13
@prgeor
Copy link
Collaborator

prgeor commented Nov 19, 2024

@vdahiya12 please update

Motivation and Context
How Has This Been Tested?

Signed-off-by: Vaibhav Dahiya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants