[CRM][DASH] Add the possibility of querying availability for OIDs. #1245
Conversation
oleksandrivantsiv
commented
May 18, 2023
oleksandrivantsiv
commented
- Add support for DASH resource availability to VirtualSwitchSaiInterface.
- Add support for DASH resource availability to VirtualSwitchSaiInterface.
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@oleksandrivantsiv could you please track failures and rerun if needed? |
|
/azp run Azure.sonic-sairedis |
|
Commenter does not have sufficient privileges for PR 1245 in repo sonic-net/sonic-sairedis |
|
Seems like there is build error nit related to this change |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-sairedis |
|
Commenter does not have sufficient privileges for PR 1245 in repo sonic-net/sonic-sairedis |
| else if ((objectType == (sai_object_type_t)SAI_OBJECT_TYPE_VNET) || | ||
| (objectType == (sai_object_type_t)SAI_OBJECT_TYPE_ENI) || | ||
| (objectType == (sai_object_type_t)SAI_OBJECT_TYPE_ENI_ETHER_ADDRESS_MAP_ENTRY) || | ||
| (objectType == (sai_object_type_t)SAI_OBJECT_TYPE_INBOUND_ROUTING_ENTRY) || | ||
| (objectType == (sai_object_type_t)SAI_OBJECT_TYPE_OUTBOUND_ROUTING_ENTRY) || | ||
| (objectType == (sai_object_type_t)SAI_OBJECT_TYPE_PA_VALIDATION_ENTRY) || | ||
| (objectType == (sai_object_type_t)SAI_OBJECT_TYPE_OUTBOUND_CA_TO_PA_ENTRY) || | ||
| (objectType == (sai_object_type_t)SAI_OBJECT_TYPE_DASH_ACL_GROUP) || | ||
| (objectType == (sai_object_type_t)SAI_OBJECT_TYPE_DASH_ACL_RULE)) |
There was a problem hiding this comment.
why those specific types ? do they need to be listed explicitly, seems like all of t hem are experimental objects, maybe you could use compare ?
you could get object_info from sai_metadata_get_object_type_info(ot) (check for null) on top of the function and then use info->isexperimental flag,
or if objectType >= SAI_OBJECT_TYPE_MAX
There was a problem hiding this comment.
those are the DASH objects that we use and want to test in CRM DASH VS tests. Not all experimental objects are resources, so info->isexperimental flag and objectType >= SAI_OBJECT_TYPE_MAX are redundant.
There was a problem hiding this comment.
then use flag md->isresourcetype ?
|
please update branch and resolve conflits |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@kcudnik , @oleksandrivantsiv , can we merge this? |
|
@prsunny from my pov the PR is ready to merge. |
