Turn on SAI attribute version validation #1477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per sonic-net/sonic-buildimage#20725 attribute validation must be enabled otherwise failures will be observed. Not sure why this isn't default.
kcudnik
approved these changes
Dec 2, 2024
|
I'm assuming the test failures are unrelated to this PR |
|
I saw they reverted the SAI updates to branch 202411, but then didn't reapply after branching? seems odd |
Those chcnages were reverted on master because of brcm issue, I'm not sure if they will be applied on 202411, @yxieca can you confirm? |
|
well, more interested when they'll bring back to master .... i doubt will go into 202411 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per sonic-net/sonic-buildimage#20725 attribute validation must be enabled otherwise failures will be observed. This prevents the ASIC from coming online on broadcom and likely other vendors.
Signed-off-by: Brad House