Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNMP agent enhancements and optimizations #187

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

anand-kumar-subramanian
Copy link

@anand-kumar-subramanian anand-kumar-subramanian commented Dec 23, 2020

Contains support for new RFCs, enhancements to the existing RFCs.

Verified by running SNMP walk at the top

Following are the enhancements and optimizations done in the SNMP agent.

1)Added trap infra support to send db notification as snmp traps.

2)Added support for linkup/linkDown traps.

3)Added support for AgentX NotifyPDU for communicating with master agent.

4)Added support for returning sysObjectId based on platform type.

5)SNMP support for port aliasing

6)Added support for ifPhysAddress

7)Added support ifLastChange

8)Vlan and Loopback interfaces are part of ifTable

9)Supoort for configuration change trap.

10)Support for rfc4188.

Added 1) dot1dBaseBridgeAddress 2) dot1dBaseNumPorts 3) dot1dBaseType 4) dot1dBasePort

  1. dot1dBasePortIfIndex 6) dot1dBasePortDelayExceededDiscards 7) dot1dBasePortMtuExceededDiscards

  2. dot1dTpAgingTime

11)Support for rfc4363

  1. dot1qBase 2) dot1qFdbTable 3) dot1qTpFdbTable 4) dot1qVlanNumDeletes 5) dot1qVlanCurrentTable

  2. dot1qVlanStaticTable 7) dot1qPvid

@svc-acs
Copy link
Collaborator

svc-acs commented Dec 23, 2020

Can one of the admins verify this patch?

@lgtm-com
Copy link

lgtm-com bot commented Dec 23, 2020

This pull request introduces 16 alerts when merging 3dfd9b4 into 381ae47 - view on LGTM.com

new alerts:

  • 10 for Unused import
  • 3 for Except block handles 'BaseException'
  • 1 for Unnecessary pass
  • 1 for Variable defined multiple times
  • 1 for Redundant assignment

@lgtm-com
Copy link

lgtm-com bot commented Dec 23, 2020

This pull request introduces 5 alerts when merging 70619e3 into 025483a - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Unnecessary pass
  • 1 for Syntax error
  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Dec 23, 2020

This pull request introduces 4 alerts when merging 4ce8e46 into 025483a - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Unnecessary pass
  • 1 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented Dec 23, 2020

This pull request introduces 3 alerts when merging ac918c2 into 025483a - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Unnecessary pass

@lguohan
Copy link
Contributor

lguohan commented Jan 13, 2021

can you provide more descriptions? what are the new rfc? improvements?

@qiluo-msft
Copy link
Contributor

Please resolve the conflicts

@qiluo-msft
Copy link
Contributor

qiluo-msft commented Apr 12, 2021

I read quickly the code and see lots of great contribution mixed into one PR. Could you please split into multiple individual PRs on each topics?

The topics 4~8 looks incremental and relative easy to be reviewed.
The topics 10~11 introduces new MIBs and need more effort to review.
The topics 1~3 are quite new use cases and we need careful study the design and investigate the code in close details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants