Add noreturn

Signed-off-by: Ze Gan <[email protected]>
sonic-net · Nov 24, 2023 · d289a9f · d289a9f
1 parent 8a087c0
commit d289a9f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/common/redisreply.cpp b/common/redisreply.cpp
@@ -507,6 +507,9 @@ string RedisReply::formatTupleReply(struct redisReply **element, size_t elements
     return swss::join(", ", '(', ')', elementvector.begin(), elementvector.end());
 }
 
+#ifndef DASH_API_INSTALLED
+[[noreturn]]
+#endif
 string RedisReply::formatPbReply(struct redisReply **element, size_t elements, const string &key)
 {
 #ifdef DASH_API_INSTALLED
@@ -530,9 +533,9 @@ string RedisReply::formatPbReply(struct redisReply **element, size_t elements, c
             [](char c){ return c == ':' || c == '|';}));
 
     return dash::PbBinaryToJsonString(table_name, pb_buffer);
-#endif
+#else
     throw runtime_error("Dash API is not installed");
-    return "";
+#endif
 }
 
 string RedisReply::formatStringWithQuot(const string &str)

diff --git a/common/redisreply.h b/common/redisreply.h
@@ -4,7 +4,6 @@
 #include <hiredis/hiredis.h>
 #include <string>
 #include <stdexcept>
-
 #include "rediscommand.h"
 
 namespace swss {