Support async DB update for both ZMQ producer&consumer table. #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Oct 3, 2023
qiluo-msft
reviewed
Oct 3, 2023
Pterosaur
reviewed
Oct 9, 2023
common/zmqconsumerstatetable.h
Outdated
| #include "selectableevent.h" | ||
| #include "table.h" | ||
| #include "zmqserver.h" | ||
|
|
||
| #define MQ_RESPONSE_MAX_COUNT (4*1024*1024) |
There was a problem hiding this comment.
This MACRO has been defined in asyncdbupdater.h, why redefine it?
There was a problem hiding this comment.
Fixed, remove these dupe macro
qiluo-msft
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Some scenarios require sonic-gnmi side update data to APPL_DB.
How I did it
Move async DB update code to AsyncDBUpdater.
Reuse AsyncDBUpdater in both ZmqProducerStateTable and ZmqConsumerStateTable
How to verify it
Pass all UT and E2E test cases.
Add new UT.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Support async DB update for both ZMQ producer&consumer table.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)