Update sonic-swss-common for compilation on Bookworm #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Oct 26, 2023
| @@ -400,14 +400,14 @@ EventSubscriber::prune_track() | |||
| map<time_t, vector<runtime_id_t> > lst; | |||
|
|
|||
| /* Sort entries by last touched time */ | |||
| for(const auto e: m_track) { | |||
| for(const auto &e: m_track) { | |||
There was a problem hiding this comment.
@zbud-msft Could you help review events related code?
There was a problem hiding this comment.
@zbud-msft Reminder for this
qiluo-msft
approved these changes
Oct 26, 2023
This header file comes from an external package, and a very old version of the header file has been checked into this repo. This will cause problems for the upcoming Bookworm upgrade. Change references to the header file to use the Debian package nlohmann-json-dev, and remove json.hpp from this repo. Signed-off-by: Saikrishna Arcot <[email protected]>
Signed-off-by: Saikrishna Arcot <[email protected]>
Signed-off-by: Saikrishna Arcot <[email protected]>
Signed-off-by: Saikrishna Arcot <[email protected]>
saiarcot895
force-pushed
the
bookworm-changes
branch
from
189e25d to
77452be
Compare
zbud-msft
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following two changes:
json.hppform thenlohmann-json-devpackage instead of having a local copy. This is because this version as-is now has compilation errors on Bookworm, and this file is coming from an external source.