sonic-utilities : Added support for L2_TABLE_TYPE in acl-loader #2516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related pull requests:
sonic-net/sonic-swss#2554
#2516
What I did
Added L2 table type support in acl-loader utility.
How I did it
ACL supports only L3 and L3V6 table type. There is no support for matching L2 table type.
From CLICK for command "config acl update full <file.json>", provided support for L2 table type and L2 fields like src mac & dst mac.
How to verify it
Create L2 Table from CLICK
"config acl add table -s ingress -p <table_name> L2"
Add rules using openconfig json format for supported fields "config acl update full/incremental <file.json>"
"source-mac": "00:00:00:11:11:12",
"source-mac-mask": "00:00:00:ff:ff:ff",
"destination-mac": "00:00:00:11:11:13",
"destination-mac-mask": "00:00:00:ff:ff:ff",
"ethertype": "ETHERTYPE_ARP"
Validate commands "show acl table"
Validate commands and fields in "show acl rule"
Validate commands "aclshow -a" /* Ensured that the counters are hitting the relevant rule */
All the rules are added for each field and combinations as well. and each field tested with traffic in Broadcom based platform.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
show acl rule
L2_TABLE RULE_1 1 FORWARD DST_MAC: 00:00:00:22:22:22/00:00:00:ff:ff:ff
ETHER_TYPE: 0x0800
SRC_MAC: 00:00:00:11:11:11/00:00:00:ff:ff:ff