Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure 277 #451

Closed
wants to merge 2 commits into from
Closed

Azure 277 #451

wants to merge 2 commits into from

Conversation

madhupalu
Copy link
Contributor

commit c718943 (HEAD -> azure-277)
Author: madhu Pal [email protected]
Date: Wed Jan 30 04:20:26 2019 +0000

[config/main.py] Fixed typo in passing arguments -port_namee (#277)

Signed-off-by: madhu Pal <[email protected]>

@madhupalu
Copy link
Contributor Author

madhupalu commented Jan 30, 2019

Prince,
Could you help me to resolve the merge conflicts.

Quick note - To fix #277, the following pull request must go
sonic-net/sonic-py-swsssdk#47
Could you please review and merge along with this change.

Thanks
-Madhu

@stcheng
Copy link
Contributor

stcheng commented Jan 30, 2019

Could you change the pull request title?

@prsunny
Copy link
Contributor

prsunny commented Jan 30, 2019

You can close this PR and create a new one with the fix and also the test results. As Shuotian mentioned, please use appropriate title for the PRs with command and test outputs

@madhupalu madhupalu closed this Jan 31, 2019
@madhupalu
Copy link
Contributor Author

Sure.
one quick question - how can I raise pull request with changes spread across multiple repos ex: sonic-utilties & sonic-py-swsssdk? shall we raise two pull requests or combined one? if combined one how can we do?

@prsunny
Copy link
Contributor

prsunny commented Jan 31, 2019

You should raise two pull-requests and specify in PR if it is dependent on other. This way, merge can wait until the dependent PR is approved and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants