add windows exclusions for non-agent targets

sonroyaalmerol · Dec 6, 2024 · f347e58 · f347e58
1 parent dd46cfd
commit f347e58
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 23 deletions.
diff --git a/internal/backend/backup/jobrun.go b/internal/backend/backup/jobrun.go
@@ -110,13 +110,17 @@ func RunBackup(job *store.Job, storeInstance *store.Store, waitChan chan struct{
 		"--backup-id", backupId,
 	}
 
+	if !isAgent {
+		for _, exclusion := range store.WindowsStapleExclusions {
+			cmdArgs = append(cmdArgs, "--exclude", exclusion)
+		}
+	}
+
 	if job.Namespace != "" {
-		cmdArgs = append(cmdArgs, "--ns")
-		cmdArgs = append(cmdArgs, job.Namespace)
+		cmdArgs = append(cmdArgs, "--ns", job.Namespace)
 	} else if isAgent && job.Namespace == "" {
 		newNamespace := strings.ReplaceAll(job.Target, " - ", "/")
-		cmdArgs = append(cmdArgs, "--ns")
-		cmdArgs = append(cmdArgs, strings.ReplaceAll(job.Target, " - ", "/"))
+		cmdArgs = append(cmdArgs, "--ns", strings.ReplaceAll(job.Target, " - ", "/"))
 
 		_ = CreateNamespace(newNamespace, job, storeInstance)
 	}

diff --git a/internal/store/db.go b/internal/store/db.go
@@ -127,6 +127,14 @@ func (store *Store) CreateTables() error {
 	}
 
 	if exclusionCheck != nil {
+		for _, path := range WindowsStapleExclusions {
+			_ = store.CreateExclusion(Exclusion{
+				Path:     path,
+				IsGlobal: true,
+				Comment:  "Generated from default list of exclusions",
+			})
+		}
+
 		for _, path := range defaultExclusions {
 			_ = store.CreateExclusion(Exclusion{
 				Path:     path,

diff --git a/internal/store/default_exclusions.go b/internal/store/default_exclusions.go
@@ -1,28 +1,31 @@
 package store
 
-var defaultExclusions = []string{
-	`/hiberfil.sys`,
-	`/pagefile.sys`,
-	`/swapfile.sys`,
-	`/autoexec.bat`,
-	`/Config.Msi`,
-	`/Documents and Settings`,
-	`/Recycled`,
-	`/Recycler`,
-	`/$$Recycle.Bin`,
-	`/Recovery`,
-	`/Program Files`,
-	`/Program Files (x86)`,
-	`/ProgramData`,
-	`/PerfLogs`,
-	`/Windows`,
-	`/Windows.old`,
-	`/$$WINDOWS.~BT`,
-	`/$$WinREAgent`,
+var WindowsStapleExclusions = []string{
+	`hiberfil.sys`,
+	`pagefile.sys`,
+	`swapfile.sys`,
+	`autoexec.bat`,
+	`Config.Msi`,
+	`Documents and Settings`,
+	`Recycled`,
+	`Recycler`,
+	`$$Recycle.Bin`,
+	`Recovery`,
+	`Program Files`,
+	`Program Files (x86)`,
+	`ProgramData`,
+	`PerfLogs`,
+	`Windows`,
+	`Windows.old`,
+	`$$WINDOWS.~BT`,
+	`$$WinREAgent`,
 	"$RECYCLE.BIN",
 	"$WinREAgent",
 	"System Volume Information",
 	"Temporary Internet Files",
+}
+
+var defaultExclusions = []string{
 	`Microsoft/Windows/Recent`,
 	`Microsoft/**/RecoveryStore**`,
 	`Microsoft/**/Windows/**.edb`,