Fix TypeError: issubclass() arg 1 must be a class in nested model lis…

…t code
sopherapps · Dec 12, 2022 · ac8a42b · ac8a42b
1 parent 1598d9c
commit ac8a42b
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/pydantic_redis/model.py b/pydantic_redis/model.py
@@ -184,9 +184,12 @@ def __eager_load_nested_model_lists(
         [{"___books": ["id1", "id2"]}] becomes [{"books": [Book{"id": "id1", ...}, Book{"id": "id2", ...}]}]
         """
         field = strip_leading(prefixed_field, IN_LIST_NESTED_MODEL_PREFIX)
-        model_type = field_types.get(field).__args__[0]
-        # in case the field is Optional e.g. books: Optional[List[Model]]
-        if not issubclass(model_type, Model):
+        field_type = field_types.get(field)
+        model_type = field_type.__args__[0]
+
+        # in case the field is Optional e.g. books: Optional[List[Model]], an alias for Union[List[Model], None]
+        is_optional = field_type.__origin__ == Union
+        if is_optional:
             model_type = model_type.__args__[0]
 
         for record in data: