Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] 파트 안내 메세지 추가 #270

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Conversation

eonseok-jeon
Copy link
Member

Related Issue : Closes #269


🧑‍🎤 Summary

  • 파트 선택 시 지원할 때 주의할 점에 대한 안내 메세지 보여주기

🧑‍🎤 Screenshot

스크린샷 2024-07-30 오전 3 22 36

🧑‍🎤 Comment

디자인

디자인은 지원하기 페이지 젤 윗 부분의 지원서 안내 메세지와 동일하게 가져갔어요
스크린샷 2024-07-30 오전 3 23 19
서버에서 텍스트를 그대로 받아오기 때문에 강조하는 부분에 대해서는 아직 처리를 못했는데 이건 다음 기수 때 추가해 봐도 좋을 거 같아요

사용법

admin 페이지에서 질문 적는 곳에 안내 메세지 작성하고 글자 수 제한을 0으로 설정한 뒤 저장하면 돼요!

@eonseok-jeon eonseok-jeon requested a review from lydiacho July 29, 2024 18:27
@eonseok-jeon eonseok-jeon self-assigned this Jul 29, 2024
@eonseok-jeon eonseok-jeon linked an issue Jul 29, 2024 that may be closed by this pull request
Copy link

height bot commented Jul 29, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

cloudflare-workers-and-pages bot commented Jul 29, 2024

Deploying sopt-recruiting-frontend with  Cloudflare Pages  Cloudflare Pages

Latest commit: 410df7a
Status: ✅  Deploy successful!
Preview URL: https://365b4c4a.sopt-recruiting-frontend.pages.dev
Branch Preview URL: https://feat--269-part-info.sopt-recruiting-frontend.pages.dev

View logs

Copy link
Member

@lydiacho lydiacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

공통 섹션 외에 파트 섹션만 해당 처리 해주신거 맞지요?
이후 확장성을 위해 공통 섹션에도 해당 처리 쇽샥 해두면 좋을 것 같아요 물론 안해줘도 완전 무방할 것 같습니다~~~
🥇

image

@lydiacho
Copy link
Member

  • 해당 형태 (디자인) 및 가능 여부 인우님한테 그 스레드로 말씀드리면 될 것 같아유 !! 혹시 잊으셧을까봐 리마인드~~

@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 29, 2024
@eonseok-jeon
Copy link
Member Author

@lydiacho

공통 부분도 구현 완료~
스크린샷 2024-07-30 오전 4 26 40

@eonseok-jeon eonseok-jeon merged commit 1baa595 into develop Jul 29, 2024
1 check passed
@eonseok-jeon eonseok-jeon deleted the feat/#269-part-info branch July 29, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 파트 안내 메세지 추가
2 participants