Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SP0/hotfix] ASAP 썸네일 임시 이미지로 대체 #163

Closed
wants to merge 2 commits into from

Conversation

solar3070
Copy link
Member

Summary

Screenshot

엑박 임시 썸네일
image image

Comment

  • 기획 파트 모집 서류에서 해당 페이지가 필요하다고 말씀하셔서 일단 오류 해결 전까지 임시 이미지로 대체하고자 합니다.

@solar3070 solar3070 self-assigned this Sep 4, 2023
Copy link
Contributor

@f0rever0 f0rever0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했어요! 고생하셨습니다✨

Comment on lines 22 to 33
project.name === 'ASAP' ? (
<div className={styles['image-wrapper']}>
<Image
className={`${GTM_CLASS.projectCard}`}
src={asap}
width={316}
height={176}
alt="thumbnail"
/>
</div>
) : (
RepresentativeImageRender(project.logoImage, project?.thumbnailImage)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment;

와우... project.name으로 구별해서 넣으셨군요! 서버에서 가능하다고 생각했는데 최고입니다!

@solar3070 solar3070 changed the title [SPR 0 / hotfix] ASAP 썸네일 임시 이미지로 대체 [SP0/hotfix] ASAP 썸네일 임시 이미지로 대체 Sep 4, 2023
@pull-request-size pull-request-size bot added size/XS and removed size/S labels Sep 6, 2023
Copy link
Member

@SeojinSeojin SeojinSeojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

체고입니다 ..!! 당돌고딩과의 혈투 ... ...

이 PR은 머지될 diff가 없어서 일단 develop에 머지하진 않고 close하겠습니다!

다음에도 당돌고딩이 나타나면 참고할 수 있는 좋은 재료로 참고할 PR로 역사 속에 남을 것이에요~!!

@solar3070 solar3070 deleted the feat/#162-temp-thumbnail branch September 14, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASAP 썸네일 임시 이미지로 대체
3 participants