Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SP1] 리쿠르팅, 후원페이지 amplitude tracking code 심기 #199

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

f0rever0
Copy link
Contributor

Summary

close #197
리쿠르팅, 후원페이지 앰플리튜드 트래킹 코드를 심었습니다!

Screenshot

Comment

아래 두개의 탭은 같은 컴포넌트를 사용해서 props로 트래킹 코드 네임(amplitudeTrackingName)을 넘겨주도록 수정하였습니다!
image
image

      <S.TabBar>
        {allTabs.map((tab) => (
          <Tab
            key={tab.value}
            onClick={() => {
              onTabClick(tab.value);
              track(amplitudeTrackingName, { part: tab.value });
            }}
            tab={tab}
            selected={selectedTab === tab.value}
          />
        ))}
      </S.TabBar>

@f0rever0 f0rever0 self-assigned this Sep 24, 2023
@pull-request-size pull-request-size bot added size/L and removed size/S labels Sep 24, 2023
Copy link
Member

@SeojinSeojin SeojinSeojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

훌륭합니다!!!!!!!!

@f0rever0 f0rever0 merged commit 7e0052e into develop Sep 28, 2023
1 check passed
@f0rever0 f0rever0 deleted the feat/#197-amplitude-tracking-code branch September 28, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

앰플리튜드 "리쿠르팅/후원페이지" 트래킹 코드 심기
3 participants